Add feature select step to recipe #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| --- | ||
| feature_select: | ||
| perform: true | ||
| output_basedir: data/profiles |
There was a problem hiding this comment.
Pointing out that here as in the [normalize][output_basedir] (mentioned in my review of #16) the output_basedir is a nested folder and we have up until now used only single folders, I believe.
Again, not necessarily a problem, just pointing it out.
There was a problem hiding this comment.
Noting also here the discussion we had in #16 (comment)
ErinWeisbart
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, we add the feature selection step to the pooled cell painting recipe. We use
pycytominer.feature_select()to perform the feature selection, and we include all options in an updated config file.We will not support feature selection on individual site-specific single-cell files (for now at least).