Hide readviz by default #1556
Merged
Hide readviz by default #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyhgrant
force-pushed
the
hide-readviz-by-default
branch
from
97a53e7 to
9953610
Compare
rileyhgrant
force-pushed
the
hide-readviz-by-default
branch
from
9953610 to
42a8a5a
Compare
phildarnowsky-broad
requested changes
Jun 12, 2024
| @@ -307,8 +325,8 @@ class ReadData extends Component<ReadDataProps, ReadDataState> { | |||
| } | |||
|
|
|||
| loadInitialTracks() { | |||
| ;['exome', 'genome'].forEach((exomeOrGenome) => { | |||
| ;['het', 'hom', 'hemi'].forEach((category) => { | |||
| ;(['exome', 'genome'] as SequencingType[]).forEach((exomeOrGenome) => { | |||
There was a problem hiding this comment.
if this works, it'd be more idiomatic to write ['exome', 'genome'].forEach((exomeOrGenome: SequencingType) => .... I think TS should be able to infer that properly. Same deal in the next line.
There was a problem hiding this comment.
I would have liked that better too, but unfortunately TS complains about doing it that way, as the forEach is being called on an array of strings.
browser/src/ReadData/ReadData.tsx
Outdated
| <CheckboxInput | ||
| id="always-load" | ||
| checked={alwaysLoad} | ||
| onChange={(e: any) => { |
There was a problem hiding this comment.
there should be a type you can use for e here, MouseEvent or something similar IIRC
|
Screenshots of the UI: |
phildarnowsky-broad
approved these changes
Jun 17, 2024
sjahl
approved these changes
Jun 18, 2024
rileyhgrant
force-pushed
the
hide-readviz-by-default
branch
3 times, most recently
from
d43f30a to
e8d03e6
Compare
rileyhgrant
force-pushed
the
hide-readviz-by-default
branch
from
db93cca to
a92857d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #633
Hides readviz by default on Variant pages to try and save on egress fees.
Gives two options,
localStorageto save the value of this on load and when toggling thisAlso adds tracking to these two buttons to try and see how often people use these