Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(graphql-api): revert es aliases to generic names #1553

Merged
merged 1 commit into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion graphql-api/src/queries/copy-number-variant-queries.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { fetchAllSearchResults } from './helpers/elasticsearch-helpers'

const GNOMAD_COPY_NUMBER_VARIANTS_V4_INDEX = 'v4p1_gnomad_v4_cnvs'
const GNOMAD_COPY_NUMBER_VARIANTS_V4_INDEX = 'gnomad_v4_cnvs'

type CnvDatasetId = 'gnomad_cnv_r4'
type DatasetDependentQueryParams = {
Expand Down
2 changes: 1 addition & 1 deletion graphql-api/src/queries/gene-queries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { fetchAllSearchResults } from './helpers/elasticsearch-helpers'

const GENE_INDICES = {
GRCh37: 'genes_grch37',
GRCh38: 'v4p1_genes_grch38',
GRCh38: 'genes_grch38',
}

const _fetchGeneById = async (esClient: any, geneId: any, referenceGenome: any) => {
Expand Down
4 changes: 1 addition & 3 deletions graphql-api/src/queries/structural-variant-queries.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,7 @@ const makeMockClient = (response: any) => {
}

const expectedIndex = (datasetId: SvDatasetId) =>
datasetId === 'gnomad_sv_r4'
? 'v4p1_gnomad_structural_variants_v3'
: 'gnomad_structural_variants_v2'
datasetId === 'gnomad_sv_r4' ? 'gnomad_structural_variants_v3' : 'gnomad_structural_variants_v2'

describe('fetchStructuralVariantById', () => {
const variantId = 'dummy-variant'
Expand Down
2 changes: 1 addition & 1 deletion graphql-api/src/queries/structural-variant-queries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { isEmpty } from 'lodash'
import { fetchAllSearchResults } from './helpers/elasticsearch-helpers'

const GNOMAD_STRUCTURAL_VARIANTS_V2_INDEX = 'gnomad_structural_variants_v2'
const GNOMAD_STRUCTURAL_VARIANTS_V3_INDEX = 'v4p1_gnomad_structural_variants_v3'
const GNOMAD_STRUCTURAL_VARIANTS_V3_INDEX = 'gnomad_structural_variants_v3'

type SvDatasetId =
| 'gnomad_sv_r2_1'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { getFlagsForContext } from './shared/flags'
import { getConsequenceForContext } from './shared/transcriptConsequence'
import largeGenes from '../helpers/large-genes'

const GNOMAD_V4_VARIANT_INDEX = 'v4p1_gnomad_v4_variants'
const GNOMAD_V4_VARIANT_INDEX = 'gnomad_v4_variants'

type Subset = 'all' | 'non_ukb'

Expand Down
Loading