Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(graphql-api): revert es aliases to generic names #1553

Merged
merged 1 commit into from
May 24, 2024

Conversation

rileyhgrant
Copy link
Contributor

@rileyhgrant rileyhgrant commented May 23, 2024

Importantly, this must be accompanied by the aliases changed in this PR (genes_grch38, gnomad_v4_variants, gnomad_structural_variants_v3, gnomad_v4_cnvs) to already have been re-pointed at the correct indices.

Just did a double check, and the current indices associated with these aliases are:

genes_grch38:             genes_grch38-2024-04-03--12-30
v4p1_genes_grch38:        genes_grch38-2024-04-03--12-30 

gnomad_v4_variants:       gnomad_v4_variants-2024-04-17--20-50   
v4p1_gnomad_v4_variants:  gnomad_v4_variants-2024-04-17--20-50   

gnomad_structural_variants_v3:      phil_demo_gnomad_structural_variants_v3-2024-04-08--18-30 
v4p1_gnomad_structural_variants_v3: phil_demo_gnomad_structural_variants_v3-2024-04-08--18-30 

gnomad_v4_cnvs:           gnomad_v4_cnvs-2024-04-24--20-12
v4p1_gnomad_v4_cnvs:      gnomad_v4_cnvs-2024-04-24--20-12 

So we should be good to merge and deploy this all smoothly.

After this PR is merged and deployed, we can safely drop the 4 aliases indices no longer referenced (the 4 above preprended with v4p1_..., e.g. v4p1_genes_grch38)

There's also some cleaning up of indices and aliases we should probably do, lots of various old indices and aliases floating around

@rileyhgrant rileyhgrant self-assigned this May 23, 2024
Copy link
Contributor

@sjahl sjahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

After this PR is merged and deployed, we can safely drop the 4 indices no longer referenced (the 4 above preprended with v4p1_..., e.g. v4p1_genes_grch38)

Just to clarify -- we would be dropping aliases not indices here, right?

@rileyhgrant
Copy link
Contributor Author

rileyhgrant commented May 24, 2024

Looks good to me.

After this PR is merged and deployed, we can safely drop the 4 indices no longer referenced (the 4 above preprended with v4p1_..., e.g. v4p1_genes_grch38)

Just to clarify -- we would be dropping aliases not indices here, right?

Whoops, yes you're right, alias not index.

@rileyhgrant rileyhgrant merged commit cdea4bf into main May 24, 2024
4 checks passed
@rileyhgrant rileyhgrant deleted the update-v4-variants-index branch May 24, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants