Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change v4.0.0 -> v4.1.0 in Dataset Selector and Metadata #1474

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Change v4.0.0 -> v4.1.0 in Dataset Selector and Metadata #1474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee91209
feat(frontend): update v4.0.0 -> v4.1.0 in dataset selector
rileyhgrant Apr 8, 2024
35debc8
feat(frontend): update banner for v4.1.0
rileyhgrant Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions browser/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import { hot } from 'react-hot-loader/root'
import { BrowserRouter as Router, Route, useLocation } from 'react-router-dom'
import styled from 'styled-components'

import { ExternalLink } from '@gnomad/ui'

import Delayed from './Delayed'
import ErrorBoundary from './ErrorBoundary'

Expand Down Expand Up @@ -72,16 +70,7 @@ const Banner = styled.div`
}
`

const BANNER_CONTENT = (
<>
We are aware of an issue in the gnomAD v4.0 exomes where well covered variants have lower than
expected allele numbers. This issue will be fixed in the upcoming v4.1 release. For more
information, see our write-up {/* @ts-expect-error */}
<ExternalLink href="https://docs.google.com/document/d/1Xm5ZIhmkh7hv2qEfCDS6J2T0IUZYiXP8pNClTlNvCGQ/edit?usp=sharing">
here.
</ExternalLink>{' '}
</>
)
const BANNER_CONTENT = <>gnomAD v4 is now version v4.1.0</>

const App = () => {
const [isLoading, setIsLoading] = useState(true)
Expand Down
44 changes: 22 additions & 22 deletions browser/src/GenePage/__snapshots__/GenePage.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ exports[`GenePage with CNV dataset "gnomad_cnv_r4" has no unexpected changes 1`]
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -1609,7 +1609,7 @@ exports[`GenePage with SV dataset "gnomad_sv_r2_1" has no unexpected changes 1`]
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -3116,7 +3116,7 @@ exports[`GenePage with SV dataset "gnomad_sv_r2_1_controls" has no unexpected ch
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -4623,7 +4623,7 @@ exports[`GenePage with SV dataset "gnomad_sv_r2_1_non_neuro" has no unexpected c
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -6084,7 +6084,7 @@ exports[`GenePage with SV dataset "gnomad_sv_r4" has no unexpected changes 1`] =
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
</a>
</li>
<li
Expand Down Expand Up @@ -6130,7 +6130,7 @@ exports[`GenePage with SV dataset "gnomad_sv_r4" has no unexpected changes 1`] =
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -7637,7 +7637,7 @@ exports[`GenePage with non-SV dataset "exac" has no unexpected changes 1`] = `
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -9178,7 +9178,7 @@ exports[`GenePage with non-SV dataset "gnomad_cnv_r4" has no unexpected changes
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -10696,7 +10696,7 @@ exports[`GenePage with non-SV dataset "gnomad_r2_1" has no unexpected changes 1`
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -12332,7 +12332,7 @@ exports[`GenePage with non-SV dataset "gnomad_r2_1_controls" has no unexpected c
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -13968,7 +13968,7 @@ exports[`GenePage with non-SV dataset "gnomad_r2_1_non_cancer" has no unexpected
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -15604,7 +15604,7 @@ exports[`GenePage with non-SV dataset "gnomad_r2_1_non_neuro" has no unexpected
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -17240,7 +17240,7 @@ exports[`GenePage with non-SV dataset "gnomad_r2_1_non_topmed" has no unexpected
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -18876,7 +18876,7 @@ exports[`GenePage with non-SV dataset "gnomad_r3" has no unexpected changes 1`]
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -20418,7 +20418,7 @@ exports[`GenePage with non-SV dataset "gnomad_r3_controls_and_biobanks" has no u
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -21960,7 +21960,7 @@ exports[`GenePage with non-SV dataset "gnomad_r3_non_cancer" has no unexpected c
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -23502,7 +23502,7 @@ exports[`GenePage with non-SV dataset "gnomad_r3_non_neuro" has no unexpected ch
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -25044,7 +25044,7 @@ exports[`GenePage with non-SV dataset "gnomad_r3_non_topmed" has no unexpected c
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -26586,7 +26586,7 @@ exports[`GenePage with non-SV dataset "gnomad_r3_non_v2" has no unexpected chang
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -28082,7 +28082,7 @@ exports[`GenePage with non-SV dataset "gnomad_r4" has no unexpected changes 1`]
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
</a>
</li>
<li
Expand Down Expand Up @@ -28128,7 +28128,7 @@ exports[`GenePage with non-SV dataset "gnomad_r4" has no unexpected changes 1`]
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -29669,7 +29669,7 @@ exports[`GenePage with non-SV dataset "gnomad_r4_non_ukb" has no unexpected chan
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down
30 changes: 15 additions & 15 deletions browser/src/MitochondrialVariantPage/__snapshots__/MitochondrialVariantPage.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_cnv_r4 has no unexpected c
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -8722,7 +8722,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_r3 has no unexpected chang
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -17245,7 +17245,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_r3_controls_and_biobanks h
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -25768,7 +25768,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_r3_non_cancer has no unexp
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -34291,7 +34291,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_r3_non_neuro has no unexpe
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -42814,7 +42814,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_r3_non_topmed has no unexp
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -51337,7 +51337,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_r3_non_v2 has no unexpecte
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -59814,7 +59814,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_r4 has no unexpected chang
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
</a>
</li>
<li
Expand Down Expand Up @@ -59860,7 +59860,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_r4 has no unexpected chang
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -68383,7 +68383,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_r4_non_ukb has no unexpect
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -76906,7 +76906,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_sv_r2_1 has no unexpected
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -85429,7 +85429,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_sv_r2_1_controls has no un
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -93952,7 +93952,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_sv_r2_1_non_neuro has no u
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down Expand Up @@ -102429,7 +102429,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_sv_r4 has no unexpected ch
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
</a>
</li>
<li
Expand Down Expand Up @@ -102475,7 +102475,7 @@ exports[`MitochondrialVariantPage with dataset gnomad_sv_r4 has no unexpected ch
onClick={[Function]}
onKeyDown={[Function]}
>
gnomAD v4.0.0
gnomAD v4.1.0
<div
className="DatasetSelector__ItemDescription-sc-1p2fxbn-6 jjgqnf"
>
Expand Down
4 changes: 2 additions & 2 deletions browser/src/RegionPage/__snapshots__/RegionPage.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3699,7 +3699,7 @@ exports[`RegionPage with "gnomad_r4" dataset has no unexpected changes for a mit
<TrackPage>
<TrackPage__TrackPageSection>
<DocumentTitle
title="M-345-456 | gnomAD v4.0.0"
title="M-345-456 | gnomAD v4.1.0"
/>
<GnomadPageHeading
datasetOptions={
Expand Down Expand Up @@ -3849,7 +3849,7 @@ exports[`RegionPage with "gnomad_r4" dataset has no unexpected changes for a non
<TrackPage>
<TrackPage__TrackPageSection>
<DocumentTitle
title="12-345-456 | gnomAD v4.0.0"
title="12-345-456 | gnomAD v4.1.0"
/>
<GnomadPageHeading
datasetOptions={
Expand Down
2 changes: 1 addition & 1 deletion browser/src/Searchbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export default withRouter((props: any) => {
}}
>
<optgroup label="GRCh38">
<option value="gnomad_r4">gnomAD v4.0.0</option>
<option value="gnomad_r4">gnomAD v4.1.0</option>
<option value="gnomad_r3">gnomAD v3.1.2</option>
<option value="gnomad_sv_r4">gnomAD SVs v4</option>
<option value="gnomad_cnv_r4">gnomAD CNVs v4.0</option>
Expand Down
2 changes: 1 addition & 1 deletion browser/src/ShortTandemRepeatPage/__snapshots__/ShortTandemRepeatPageContainer.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1966,7 +1966,7 @@ query ShortTandemRepeat($strId: String!, $datasetId: DatasetId!) {
exports[`ShortTandemRepeatPageContainer with dataset gnomad_r4 queries API with correct parameters 1`] = `
<Page>
<DocumentTitle
title="ATXN1 | Tandem Repeat | gnomAD v4.0.0"
title="ATXN1 | Tandem Repeat | gnomAD v4.1.0"
/>
<GnomadPageHeading
datasetOptions={
Expand Down
Loading
Loading