Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging of button clicks #1460

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Conversation

rileyhgrant
Copy link
Contributor

Resolves #1459

Adds small helpers / modifies existing components to optionally log button clicks

Adds logging of button clicks of:

  • Variant co-occurrence tab for table on gene page
  • genetic ancestry group frequency toggles on variant page
  • more info button for MNV
  • Download clicks for v2 LD matrices (hopefully an acceptable proxy for actual downloads)

Copy link
Contributor

@phildarnowsky-broad phildarnowsky-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one little trivial cleanup needed

@@ -37,6 +38,11 @@ const MNVSummaryList = ({ multiNucleotideVariants }: Props) => (
in {mnv.n_individuals} individual{mnv.individuals !== 1 && 's'}
{mnv.changes_amino_acids && ', altering the amino acid sequence'}.{' '}
<Link
// onClick={(event: React.MouseEvent<HTMLAnchorElement>) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple commented-out lines here

Track every toggle to the Variant Co-occurrence table on the Gene page, every time a genetic ancestry group is toggled on the Variant page frequency table, and every time a user clicks 'more info' for the multi nucleotide variant summary text
@rileyhgrant rileyhgrant force-pushed the addl-click-tracking branch from 8955084 to 41da789 Compare April 24, 2024 21:06
@rileyhgrant rileyhgrant merged commit 4e2748e into main Apr 25, 2024
1 check passed
@rileyhgrant rileyhgrant deleted the addl-click-tracking branch April 25, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track other button clicks in addition to pext
2 participants