fixup(frontend): fix variant factory typing to get typecheck passing

broadinstitute · Apr 8, 2024 · 33406ea · 33406ea
1 parent aae9fa4
commit 33406ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/browser/src/VariantList/mergeExomeAndGenomeData.spec.ts b/browser/src/VariantList/mergeExomeAndGenomeData.spec.ts
@@ -33,7 +33,6 @@ describe('mergeExomeAndGenomePopulationData', () => {
       { id: 'eur', value: 4 },
     ])
 
-    // @ts-expect-error
     const testVariant = variantFactory.build({
       variant_id: 'test_variant',
       exome: { populations: geneticAncestryGroupObjects },

diff --git a/browser/src/__factories__/Variant.ts b/browser/src/__factories__/Variant.ts
@@ -89,6 +89,7 @@ export const variantFactory = Factory.define<Variant>(({ params, associations })
   const {
     exome = null,
     genome = null,
+    joint = null,
     non_coding_constraint = null,
     clinvar = null,
     coverage = { exome: null, genome: null },
@@ -110,6 +111,7 @@ export const variantFactory = Factory.define<Variant>(({ params, associations })
     clinvar,
     exome,
     genome,
+    joint,
     lof_curations,
     in_silico_predictors,
     non_coding_constraint,
@@ -195,8 +197,8 @@ export const sequencingFactory = Factory.define<SequencingType>(({ params, assoc
   const {
     ac = 1,
     an = 1,
-    homozygote_count = null,
-    hemizygote_count = null,
+    homozygote_count = 0,
+    hemizygote_count = 0,
     filters = [],
     populations = [],
     local_ancestry_populations = [],