Use semicolon as file path separator for lua_load #2154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
✅ Deploy Preview for conkyweb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Caellian
added
enhancement
Caellian
force-pushed
the
fix/lua-load-separator
branch
from
d52a0fd to
f9a3134
Compare
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Caellian
force-pushed
the
fix/lua-load-separator
branch
from
f9a3134 to
5b95330
Compare
- Move llua_init to initialisation(), to ensure lua state is initialized before dealing with config file. This means that it's effectively static for all contexts which need to rely on lua state - and doesn't need to be checked everywhere. - Move package.path setup to llua_init so globals all get set from the same place. - Handle paths with spaces correctly in to_real_path by wrapping them with double quotes. - Testing: - that old space delimiter still works. - new semicolon delimiter works. - empty file names are ignored. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
brndnmtthws
approved these changes
Feb 17, 2025
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lua_loadconfig option previously expected space separated list of file names, it can now handle names with spaces if ';' delimiter is used.to_real_pathnow properly handles names with spaces as well.Moved call to
llua_loadfromlua_loadcode toinitialisationso that lua state gets loaded right before any config variables are handled (simplifies global state init).Improved performance a tiny bit where practical.
Testing
lua_loadget called multiple times previously?