Memoize resource URLs for major performance gain #915
Conversation
|
Your Render PR Server URL is https://bridgetown-beta-pr-915.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-crd97a1u0jms73enl140. |
|
Your Render PR Server URL is https://bridgetown-api-pr-915.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-crd97b1u0jms73enl1cg. |
|
Glad you are seeing benefits too! A bit pedantic, but the way this is implemented feel more like a pre-calculation than a memoization ;). I don't know the overall flow of the system, but since the place where you set the instance variables is not the place where you produce the value nor the place where you need it, it feels like the values could sometimes be calculated for nothing. Visually, using ||= directly in the relative_url and absolute_url is a much more common pattern. So much so I thought it was a typo when I first saw it. |
|
@MaxLap You're right, I was experimenting with different patterns and testing the outcome, and I landed on that one without it needing to be like that. I've updated to |
Resolves #914
Awesome detective work by @MaxLap, we're able to get full build performance gains of 15-25% or maybe even higher! Apparently the code to determine relative/absolute URLs for resources is somewhat expensive, and repeating that constantly throughout template rendering really adds up. This PR memoizes the values upon resource read, and resets them if there's a fast refresh (in case the permalink was changed or whatever).