Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed localization of paginated resources error #790

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

jclusso
Copy link
Contributor

@jclusso jclusso commented Aug 4, 2023

This is a 🐛 bug fix.

Summary

I'm not sure if this is the right way to go about this. Additionally, there are no tests because I couldn't find any examples of testing paginate at all.

Fixes #789

@jaredcwhite
Copy link
Member

I think you're on the right track…just need to tighten up the string sub.

@jaredcwhite jaredcwhite added this to the 1.4 milestone Aug 22, 2023
@jaredcwhite jaredcwhite merged commit 50d4233 into bridgetownrb:main Oct 10, 2023
0 of 4 checks passed
@jclusso jclusso deleted the fix_pagination_localization branch October 10, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination and multi locales
2 participants