Add T computation for Ti and Zr in Rutile and zircon, from Ferry and Watson, 2007 #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I needed this so I've implemented the functions that gives temperature from Zr and Ti in zircon and rutile (only the ones giving Ti and Zr were implemented before).
Tests were also added.
Just a more general question, is there a reason why the package Measurements.jl is not used in this package? I think it would be a nice feature to have uncertainty propagated from this kind of functions.
I was thinking about something like that to not break anything:
What do you think?
Also, I have local tests failure unrelated to this PR due to the test of Perplex on line 245 of testGeochemistry.jl (I am on Mac). That would probably be fixed by using the Perple_X_jll at some point.
Cheers,