Fix bug Rho found in centroid

brenhinkeller · Aug 2, 2023 · 607f4d6 · 607f4d6
1 parent 93f19d4
commit 607f4d6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/utilities/GIS.jl b/src/utilities/GIS.jl
@@ -456,7 +456,7 @@
     function spherical(x::Number, y::Number, z::Number)
         ρ = sqrt(x^2 + y^2 + z^2)
         φ = acos(z/ρ)
-        θ = atan(y/x)
+        θ = atan(y,x)
         return ρ, φ, θ
     end
     export spherical

diff --git a/test/testUtilities.jl b/test/testUtilities.jl
@@ -77,9 +77,12 @@
 
     # Centroid of a set of lats and lons on a sphere
     lats, lons = [-1, 1, 0, 0.], [0, 0, -1, 1.]
-    @test all(StatGeochem.centroid(lats, lons) .≈ (0.0, 0.0))
+    @test all(centroid(lats, lons) .≈ (0.0, 0.0))
+    lats, lons = [43.69852352,43.69852385,43.69944918,43.69945593,], [-116.0948702,-116.0936334,-116.0936182,-116.0948765,];
+    @test all(centroid(lats, lons) .≈ (43.698988121696146, -116.0942495750004))
 
     # Maximum arc-degree distance between a list of points on a sphere
+    lats, lons = [-1, 1, 0, 0.], [0, 0, -1, 1.]
     @test all(dist_uncert(lats, lons) .≈ (0.0, 0.0, 1.0))
     lats, lons = [0, 0, 0, 0], [0, 30, 23, 90]
     @test all(dist_uncert(lats, lons) .≈ (0.0, 34.15788270532762, 45.0))