-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite #51
Comments
That is awesome. I wanted for some time to add a simple .travis.yml to start doing simple checks since I accidentally merged in the past PRs which weren't following the format correctly. |
Great, I will be working this issue in a new branch and use this issue to keep you informed. |
#53 Found many miss written tags, works great so far. |
Great, I've added a .travis.yml for running it regularly as part of the review process. |
If you don't mind i will add '--max-line-length=100' to flake 8 because 79 is almost never enough and will cause us more problems than anything.
|
Fine by me |
Catfish Belly Frogger Farm working 22NB BaseCloud💸 Request Fundraiser of Cold Hades Ductwork System filtration guard Un-attached otherwise. Unknown point of view pertaining to payroll as to the unknown contributor |
Issue merges from #50 .
While trying to do a simple bash script of this I came across many problems since there are many ways of spacing/formatting within the same layout, the bash script was getting a bit bloated and decided to make it in python.
One of the issues of counting questions and answers are typos. So I wrote a test suit to check for these, it's working great.
Notice the missing '/' from the closing summary tag.
So my new proposal is:
Having this test suit will allow us to check our commits before pushing thus improving the general quality.
Also we could land a CI pipe for new pull requests, offering faster feedback to contributors.
The text was updated successfully, but these errors were encountered: