Upgrade from Chromium 134 to Chromium 135 #27522
Draft
+3,906
−3,984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/run-network-audit
|
A Storybook has been deployed to preview UI for the latest push |
cdesouza-chromium
force-pushed
the
cr135
branch
3 times, most recently
from
cd90ed8 to
c305436
Compare
This override had to be update as the category declaration has been updated for all those listed. Chromium change: https://chromium.googlesource.com/chromium/src/+/32b001c89dc2f186bfebe1d19a85fc74c61750eb commit 32b001c89dc2f186bfebe1d19a85fc74c61750eb Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Tue Jan 7 07:44:42 2025 -0800 [tracing] Update builtin categories to use perfetto API This CL simplifies builtin categories definition, and uses SetDescription to declare existing category descriptions. Drive-by: remove some (non-exhaustive) unused categories. Bug: 343404899
This is part of chromium's restructuring of modules, and it only affects inclusion paths, and the path of certain shadow files. Chromium change: https://chromium.googlesource.com/chromium/src/+/477a5ca58b59c4102d309f502060c986bd2a9d23 commit 477a5ca58b59c4102d309f502060c986bd2a9d23 Author: Taylor Bergquist <tbergquist@chromium.org> Date: Tue Jan 7 12:40:40 2025 -0800 Move tab dragging code into its own directory. Bug: 382754501
`OverrideWebPreferences`, and `OverrideWebPreferencesAfterNavigation` have had MPArch args added to them. These arguments can be just passed along to the inherited from class, however the signature has to be corrected in brave code. Chromium change: https://chromium.googlesource.com/chromium/src/+/183b8d70288a27d142029fd529de3a89481eb0df commit 183b8d70288a27d142029fd529de3a89481eb0df Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Jan 7 10:47:18 2025 -0800 [MPArch Guest View] Make WebPreferences queried per frame tree root Different frame tree roots will require different web preferences (extension applies different settings for apps). We need to be able to query the preferences per frame tree root. Bug: 40202416
This argument was not in use in our code, and it was always being passed as nullptr. Chromium change: https://chromium.googlesource.com/chromium/src/+/d6728815328ff8d406c211e758030170ed7c36df commit d6728815328ff8d406c211e758030170ed7c36df Author: Nihar Majmudar <niharm@google.com> Date: Tue Jan 7 08:25:57 2025 -0800 [searchbox][lensoverlay] Make LensOverlay use LensSearchboxHandler. Also removes lens specific code from RealboxHandler. Adjusts unit tests to create a base SearchboxHandlerTest which is then extended to create RealboxHandlerTest and LensSearchboxHandlerTest. Change-Id: Ic04a0649bd630c93d79585ea78803ad09aa43e50 Bug: 386819657
This function used to have `need_browser_verification = false` as the last argument, and the only caller in brave was passing the default value, so the drop is inconsequential. Chromium change: https://chromium.googlesource.com/chromium/src/+/db092df3caa844ed656b0685c2ade1374505f84c commit db092df3caa844ed656b0685c2ade1374505f84c Author: Christine Hollingsworth <christinesm@chromium.org> Date: Tue Jan 7 10:26:12 2025 -0800 [Code Health] Remove stale base::Features - BrowserVerifiedUserActivation* Removes 2 stale base::Features that are disabled by default, with no active finch experiment (and have existed 10+ milestones): BrowserVerifiedUserActivationMouse BrowserVerifiedUserActivationKeyboard CL should not change current behavior. Low-Coverage-Reason: OTHER Bug: 356624074, 356622799, 40091540
As this function has been dropped, this change replaces its use with `AutocompleteInput::SplitKeywordFromInput`, as it was done in chromium too. Chromium change: https://chromium.googlesource.com/chromium/src/+/c9e944bea82550ec3e0973a7dd8a4a093f595a75 commit c9e944bea82550ec3e0973a7dd8a4a093f595a75 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Jan 7 08:12:40 2025 -0800 [omnibox] Moves static methods processing input for keywords to ACInput Bug: 379111291
This used to be passed as a raw string, however it is now wrapped as a strong typedef. Chromium change: https://chromium.googlesource.com/chromium/src/+/5658a5f971a9ab44d4412a11d8c950a111356e57 commit 5658a5f971a9ab44d4412a11d8c950a111356e57 Author: Mikel Astiz <mastiz@chromium.org> Date: Fri Nov 29 16:25:24 2024 +0000 [signin] Adopt class GaiaId components/signin and related files SigninPrefs is excuded to reduce the delta, but otherwise most of the signin-related code is migrated to adopt class GaiaId instead of passing around std::string values to represent obfuscated gaia IDs. The class temporarily supports implicit conversion to and from std::string, which allows splitting this particular patch without tackling the entire chromium codebase. Change-Id: I5f8413f3ce6cc5f52e728ebd805118f79326b68b Bug: 380416867
These are failures fixed in M134 due to changing transient inclusions.
All uses of `GetTabSearchContainer` in Brave are in place to retrieve the tab search button. Chromium has simplified this access by providing `GetTabSearchButton()`, to allow access directly to it. Chromium change: https://chromium.googlesource.com/chromium/src/+/ceb8a5639af61500b90153c391a1f4f8a3eeb6e9 commit ceb8a5639af61500b90153c391a1f4f8a3eeb6e9 Author: Emily Shack <emshack@chromium.org> Date: Thu Jan 9 15:19:55 2025 -0800 Remove nudges from combo button The nudges have now been moved to TabStripActionContainer when the combo button is enabled, so the combo button should never include the nudges itself. This swaps out the tab search container for a tab search button, as built by the combo button. Bug: 384099721
This namespace was not named correctly in upstream before, and has been now fixed, which broke our override matching it. Chromium change: https://chromium.googlesource.com/chromium/src/+/a21ad1ffee7df2110888b6f2ad17a6ab8fd75bb9 commit a21ad1ffee7df2110888b6f2ad17a6ab8fd75bb9 Author: Lei Zhang <thestig@chromium.org> Date: Thu Jan 9 10:51:57 2025 -0800 Rename SearchEngineUtils Namespace names are suppose to be snake_case. Also fix some lint errors along the way. Change-Id: I4968708506ea77e20d4506af0471aa63d3c25d8b
The previous interface has been deprecated. Chromium change: https://chromium.googlesource.com/v8/v8/+/47a2457f77e693a5b10de5109746691f6612bb4a commit 47a2457f77e693a5b10de5109746691f6612bb4a Author: Samuel Groß <saelo@chromium.org> Date: Tue Jan 7 15:55:28 2025 +0000 Mark old String::Write* APIs as deprecated As part of https://crbug.com/373485796 we introduced new versions of these APIs. With this CL, we're now marking the old APIs as DEPRECATED. Some time in the future, we will first delete these APIs, then rename the new APIs to the old names (so drop the V2 suffix). Bug: 373485796
This feature was being disabled in brave, but now it is deleted entirely from upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/866b3f99d4dc1c06262441ed33ea3c7a4bce3b47 commit 866b3f99d4dc1c06262441ed33ea3c7a4bce3b47 Author: Gabriel Charette <gab@chromium.org> Date: Thu Jan 9 19:51:15 2025 -0800 Further cleanup stale ReduceCookieIPCs feature The feature has already been cleaned up but this was left behind. I think it's safe to remove though I'm not familiar with the policy for runtime_enabled_features.json5 Bug: 385653731 Fixed: 40061885
This function used to have an extra argument for size. Chromium change: https://chromium.googlesource.com/chromium/src/+/4fc0bb99288183c7ab331d20fe5e4473f3c3e70c commit 4fc0bb99288183c7ab331d20fe5e4473f3c3e70c Author: David Bertoni <dbertoni@chromium.org> Date: Fri Jan 10 13:53:58 2025 -0800 [Extensions] Do some more unsafe buffer use cleanup. (3) Bug: 351564777
Related Chromium change https://source.chromium.org/chromium/chromium/src/+/4e5c55b15ee78687e23badd0eed3f699349b2f15 Add share action to system share sheet Adds an extra option that creates a tab group and shares the group. Low-Coverage-Reason: TRIVIAL_CHANGE does a list of checks Bug: 386833405 Change-Id: I659add9ceeeb8c799160eb6fe12cc84289b581f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6155198
Related Chromium change https://source.chromium.org/chromium/chromium/src/+/3fded879fa9da3882befb43faecc1fb3859065af Adopt Java class GaiaId to improve type safety Introduced recently in Java in https://crrev.com/c/6110420, the class is now adopted throughout the codebase to replace String objects when it comes to gaia IDs. Bug: 380416867 Change-Id: I1ea990a1442c87f2fd2df4693c2ddb22d5ada873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6110764
This class now requires a `SearchAggregatorSuggestionsService`, however the use in brave can default to a `nullptr`. Chromium change: https://chromium.googlesource.com/chromium/src/+/81cd2f8a5022b1040e106c5064f703202356af53 commit 81cd2f8a5022b1040e106c5064f703202356af53 Author: Ananya <ananyaseelam@google.com> Date: Mon Jan 13 10:46:30 2025 -0800 [search aggregator] Connect SearchAggregator to RemoteSuggestionsService This CL adds SearchAggregatorSuggestionsService to the input parameters of the RemoteSuggestionsService constructor. This CL also adds the CreateSearchAggregatorSuggestionsRequest method which will later be used in the EnterpriseSearchAggregatorProvider. Note: The naming of SearchAggregatorSuggestionsService will change to EnterpriseSearchAggregatorSuggestionsService in a follow up CL. This is why the factory is named enterprise_search_aggregator_suggestions_service_factory. Bug: 388320853
These patches are now part of M135. Chromium change: https://chromium.googlesource.com/chromium/src/+/473d1315f86445a38b622f3114cdd04ae2ad0068 commit 473d1315f86445a38b622f3114cdd04ae2ad0068 Author: Claudio DeSouza <cdesouza@chromium.org> Date: Thu Feb 6 08:01:12 2025 -0800 Expose `JSONReader` options on test utils The use of `ParseJson` and friends in tests simplifies checks around code parsing, however making use of such utils runs into issues in cases where the test wants to support certain parsing options. This CL adds a default value that can be overriden by the caller, similar to how `JSONReader` works. Bug: 40172729
These occur sporadically due to transient dependencies changing.
This alias has been renamed to better reflect the use of `string_view`. Chromium change: https://chromium.googlesource.com/chromium/src/+/534a26b46b5d5315def1d0760b52191710e1b368 commit 534a26b46b5d5315def1d0760b52191710e1b368 Author: Lei Zhang <thestig@chromium.org> Date: Thu Jan 30 17:35:09 2025 -0800 Add base::FilePath::StringViewType Add a replacement alias for StringPieceType, now that base::StringPiece is gone. Use this replacement in base::FilePath and its unit tests. Modernize modified files to use `using` instead of `typedef` as well. Change-Id: Ib87150f54b6b7de3696a57b14bd12d92a82239ef
This is just the addition of an extra arg, however in our codebase that args is of no concern. Chromium change: https://chromium.googlesource.com/chromium/src/+/72171b42926d36e600dca37eb99268a5c24a229a commit 72171b42926d36e600dca37eb99268a5c24a229a Author: Shibalik Mohapatra <shibalik@chromium.org> Date: Wed Feb 5 13:08:06 2025 -0800 [SxS] Update the observer signature for TabGroupedStateChanged. The TabGroupedStateChanged observer will replace clients of ChangeTabGroupContents. Inorder to do so, some additional information is needed by the clients. Change-Id: I71dfc9705d115a272fa53437808fe219808a11b0
It is now required to explicitly use `ui::ImageModel::FromImageSkia` to convert a `SkiaImage` to `ImageModel`. Chromium change: https://chromium.googlesource.com/chromium/src/+/ec4049b44dd5d74660b85ced077c6268fa305e77 commit ec4049b44dd5d74660b85ced077c6268fa305e77 Author: Sangwoo Ko <sangwoo108@chromium.org> Date: Thu Feb 6 06:28:33 2025 -0800 Remove ImageView::SetImage() with ImageSkia param In favor of ui::ImageModel, this version of SetImage should be deprecated. This patch doesn't have any intended behavioral change. Bug: 40137576
This function call is not necessary anymore, as previous ViewsAX work had already moved away from the hooks this event was triggering. Chromium change: https://chromium.googlesource.com/chromium/src/+/6d3f70993e0bbb5acdb20f5981bb5b9fa9dd7116 commit 6d3f70993e0bbb5acdb20f5981bb5b9fa9dd7116 Author: Javier Contreras Tenorio (from Dev Box) <javiercon@microsoft.com> Date: Wed Feb 5 12:34:22 2025 -0800 [views-ax] Deprecate `View::NotifyAccessibilityEvent` This CL adds "deprecated" to `View::NotifyAccessibilityEvent`. TLDR: This CL just renames. In most situations, this function should not be called directly. There are a lot of events that are already sent automatically by the setters from ViewAccessibility. Soon, events will be generated automatically by the AXEventGenerator, using the AXNodeData cached in the View's ViewAccessibility. Some specific scenarios currently do require manual event generation, for example if its an event not being fired by the ViewAccessibility setters. In essence, for a lot of the events to be sent, Views authors should just need to keep the accessibility cache in ViewAccessibility updated by using the setters found in that class. There are some others that are not being sent through there currently, and firing them manually is still allowed. Once ViewsAX is completed though, most events will be generated through the AXEventGenerator, which just requires Views authors to keep the accessibility cache up to date. Bug: 325137417
This is a migration to use `ui::ColorVariant`, and for the case we have it doesn't seem to be that important. Chromium change: https://chromium.googlesource.com/chromium/src/+/0d20027475eb1e4024318d9d20454357cbab070f commit 0d20027475eb1e4024318d9d20454357cbab070f Author: Zoraiz Naeem <zoraiznaeem@chromium.org> Date: Thu Feb 6 15:30:33 2025 -0800 Migrate BubbleBorder to use `ui::ColorVariant` This is required to support ColorId for `BubbleDialogDelegate` and its related classes. Bug: b:261653838
Chromium change: https://chromium.googlesource.com/chromium/src/+/b72b8e2467302a0901da5227140b8443fb2ceb88 commit b72b8e2467302a0901da5227140b8443fb2ceb88 Author: David Roger <droger@chromium.org> Date: Thu Feb 6 00:52:13 2025 -0800 [Uno-D] Cleanup kExplicitBrowserSigninUIOnDesktop in profile menu Bug: 344531408
Chromium change: https://chromium.googlesource.com/chromium/src/+/4cefe9fea9bfad8d1f4066460a5da16019812b32 [NTP Startup] Add a cold start metric for NTP loads on Clank Current start metrics work with webpage or FDT launches. With Clank Home Frequency being increased, the current startup guardian metric's volume has been diluted. This CL adds a cold start metric to capture load times for NTP launches. The metric is recorded when FeedSurfaceProvider's view (root NTP view) calls onDraw. Specifically, the metric measures the time from activity creation to the time when the first draw pass occurs on the root view. This is similar to a previous NTP startup metric (NewTabPage.TimeToFirstDraw2) that has been deprecated, but utilizing new cold-start heuristics and recording the time from activity start instead of the start of NTP construction. Bug: 369109839
This patch had significant changes due to upstream safe buffers refactor to this file. Chromium change: https://chromium.googlesource.com/chromium/src/+/21cedfc448846e7c778352e208b153c68a024316 commit 21cedfc448846e7c778352e208b153c68a024316 Author: Matt Menke <mmenke@chromium.org> Date: Fri Feb 7 09:50:21 2025 -0800 Remove allow_unsafe_buffers from socks5_client_socket.cc. This CL restructures the read/write loop more than strictly needed to reduce use of variables and copies, using a pair of fancier IOBuffer subclasses rather than IOBuffers + a std::string + read/write size integers. Bug: 40284755
This argument for browser variation tests doesn't seem to be relevant for the existing variations test in brave. Chromium change: https://chromium.googlesource.com/chromium/src/+/7435d1e23a59fe37968c54354c362da5da5d4048 commit 7435d1e23a59fe37968c54354c362da5da5d4048 Author: Ramon Cano Aparicio <rcanoaparicio@google.com> Date: Fri Feb 7 01:17:36 2025 -0800 Fix variations safe mode browser tests. The VariationsSafeModeEndToEndBrowserTest depended on having Local-State-based seeds. Add also support for Seed File. Seed is stored in the file compressed but without being base64 encoded. Bug: 379869158
This class has been deleted from upstream for being unused, so it is being lifted directly into brave as it was still in use in our codebase. Chromium change: https://chromium.googlesource.com/chromium/src/+/1bfee585c32eb3fa81838e7d64e82e7510da517b commit 1bfee585c32eb3fa81838e7d64e82e7510da517b Author: Joe Mason <joenotcharles@google.com> Date: Fri Feb 7 08:40:39 2025 -0800 Remove unused LifecycleUnit methods (2/N) Removes GetChromeUsageTimeWhenHidden. This is the only user of the UsageClock class so removes that as well. R=fdoray Bug: 383374205
This argument is required to be passed along from an override into the chromium version of the function. Chromium change: https://chromium.googlesource.com/chromium/src/+/4ef3835f1559c2085434890df2ee53294e53d4b1 commit 4ef3835f1559c2085434890df2ee53294e53d4b1 Author: Ian Vollick <vollick@chromium.org> Date: Fri Feb 7 15:44:11 2025 -0800 Move vector icon into a resource Also adds a very simple parser and unit tests based on the existing components vector icons. Bug: None
This change corrects the violations in brave for this specific typescript linter. Chromium change: https://chromium.googlesource.com/chromium/src/+/b3cd007c92db6804407d03e7da6cd924135d3a1d commit b3cd007c92db6804407d03e7da6cd924135d3a1d Author: dpapad <dpapad@chromium.org> Date: Mon Feb 10 10:50:53 2025 -0800 CrOS WebUI: Fix violations of ESLint @typescript-eslint/require-await. This is in preparation of enabling build-time and type-aware ESLint checks in build_webui() that will catch such violations. [1] https://typescript-eslint.io/rules/require-await Bug: 394634491
As `BubbleBorder::color()` is now migrated, but `cc::PaintFlags` has not been yet, it is necessary to covert the color type for now. Chromium change: https://chromium.googlesource.com/chromium/src/+/f7a56d6ef3d597977e97140c7d13ea50cfbf33f1 commit f7a56d6ef3d597977e97140c7d13ea50cfbf33f1 Author: Zoraiz Naeem <zoraiznaeem@chromium.org> Date: Mon Feb 10 17:31:55 2025 -0800 Migrate theme tracking image views to use `ui::ColorVariant` Bug: b:394420459
This header is now deleted, and it is of no effect to remove its inclusion. Chromium change: https://chromium.googlesource.com/chromium/src/+/31a42f494da3b6d54149d7c9d3ed23d5b10a2ae9 commit 31a42f494da3b6d54149d7c9d3ed23d5b10a2ae9 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Mon Feb 10 16:42:33 2025 -0800 Cleanup IDNA metrics IDNA 2008 transition is fully launched. These metrics are no longer looked at. Bug: 40857348
cdesouza-chromium
force-pushed
the
cr135
branch
from
b76e686 to
6e212d8
Compare
This class has been deleted from upstream for being unused, so it is being lifted directly into brave as it was still in use in our codebase. Chromium change: https://chromium.googlesource.com/chromium/src/+/1bfee585c32eb3fa81838e7d64e82e7510da517b commit 1bfee585c32eb3fa81838e7d64e82e7510da517b Author: Joe Mason <joenotcharles@google.com> Date: Fri Feb 7 08:40:39 2025 -0800 Remove unused LifecycleUnit methods (2/N) Removes GetChromeUsageTimeWhenHidden. This is the only user of the UsageClock class so removes that as well. R=fdoray Bug: 383374205
Chromium change: https://chromium.googlesource.com/chromium/src/+/25845008b79c77a30986f99ee9bcbff4a81d10f6 Fix partner bookmark initialization. PartnerBookmarks were previously being initialized in ChromeActivity, but not all usage of the BookmarkBridge comes from ChromeActivity derivatives. In particular if you enable Don't Keep Activities in Android and load the BookmarkActivity, then leave, then refocus from recents, it would crash on an assertion that the partner bookmarks weren't loaded. To fix the above issue, this moves the PartnerBookmark init into the process initialization code path that runs once per application init. Subsequently, I was trying to move around when the initialization happened and the internal implementation crashes because it can not be called on the main thread (no idea why we aren't seeing this in the wild), so this adds a async way of fetching the down stream implementation (subsequent patch will utilize it). Bug: 384197258
Chromium change: https://chromium.googlesource.com/chromium/src/+/e1fc3080db043124e75031b233f0808c057cc78c Pass profile reference to BookmarkActivities. Instead of loading getLastUsedRegularProfile, the calling activity will serialize the current Profile state into the activity and the receiving BookmarkActivity will use that to load the correct Profile. While this CL enables the profile loading capability into the base class of SynchronousInitializationActivity, it is only used by BookmarkActivity and all other activities should use the legacy code path. This will be the first production usage of ProfileResolver. One assertion made in SynchronousInitializationActivity is that if the profile is not resolved, then the activity will be directly finished. This will happen in cases where the activity was started with an incognito profile, then the task is killed by the OS (for debugging, turn on don't keep activity in Android's developer settings), and then restarted from recents. I don't think any of these activities should be recreating the incognito profile that has since been destroyed, and instead should just return to the activity below it in the task. In the future, we could consider variable recovery paths, but I think that would be premature optimizations at this point. Bug: 40254448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#43864
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: