Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order intent use-case #1258

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Fix order intent use-case #1258

merged 5 commits into from
Jan 22, 2025

Conversation

saperi22
Copy link
Contributor

@saperi22 saperi22 commented Jan 17, 2025

Summary of changes

  • Update helper function to ignore case when checking for string equality.
  • Our demo app isn't setup for creating a customer when doing a checkout -- so the transaction itself fails, but this indicates that we're sending the intent=order as expected.

Checklist

  • Added a changelog entry
  • Relevant test coverage
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@saperi22 saperi22 marked this pull request as ready for review January 21, 2025 17:54
@saperi22 saperi22 requested a review from a team as a code owner January 21, 2025 17:54
@saperi22 saperi22 changed the title ignore case when checking equality Fix order intent use-case Jan 21, 2025
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Jax DesMarais-Leder <jdesmarais@paypal.com>
@saperi22 saperi22 merged commit 3816fe1 into main Jan 22, 2025
2 checks passed
@saperi22 saperi22 deleted the fix-order-intent-not-working branch January 22, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants