Cardinal Cleanup Method (#926)

* Call Cardinal cleanup method to resolve memory leak from Cardinal.getInstance * Verified via Leak Canary that the getInstance memory leak is gone
braintree · Feb 21, 2024 · 8cc2855 · 8cc2855
1 parent 19f6b3e
commit 8cc2855
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 * Venmo
   * Add `setIsFinalAmount()` to `VenmoRequest`
+* ThreeDSecure
+  * Call cleanup method to resolve `Cardinal.getInstance` memory leak
 
 ## 4.41.0 (2024-01-18)
 

diff --git a/ThreeDSecure/src/main/java/com/braintreepayments/api/CardinalClient.java b/ThreeDSecure/src/main/java/com/braintreepayments/api/CardinalClient.java
@@ -58,6 +58,8 @@ void continueLookup(ThreeDSecureResult threeDSecureResult, CardinalChallengeObse
         } catch (RuntimeException e) {
             throw new BraintreeException("Cardinal SDK cca_continue Error.", e);
         }
+
+        Cardinal.getInstance().cleanup();
     }
 
     private void configureCardinal(Context context, Configuration configuration, ThreeDSecureRequest request) throws BraintreeException {

diff --git a/ThreeDSecure/src/test/java/com/braintreepayments/api/CardinalClientUnitTest.kt b/ThreeDSecure/src/test/java/com/braintreepayments/api/CardinalClientUnitTest.kt
@@ -243,6 +243,8 @@ class CardinalClientUnitTest {
                 cardinalChallengeObserver
             )
         }
+
+        verify { cardinalInstance.cleanup() }
     }
 
     @Test
-Original file line number
+Diff line change
@@ Expand Up / @@ -243,6 +243,8 @@ class CardinalClientUnitTest { @@
                     cardinalChallengeObserver
                 )
             }
+            verify { cardinalInstance.cleanup() }
         }
         @Test
@@ Expand Down @@