Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unknown keys and add a translation in ja.js #36

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

fu2hito
Copy link
Contributor

@fu2hito fu2hito commented Feb 27, 2025

Hi, I have updated the Japanese translations.

Proposed Changes

This PR improves the Japanese translation file by:

  • Removing unknown keys from ja.js
  • Update translations

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Test passed

npm all

Language Status Missing keys Unknown keys
ja 🟢 0 0

@fu2hito fu2hito force-pushed the remove-unknownkeys-from-ja.md branch from bb7aeb0 to e80dc58 Compare February 27, 2025 14:48
- Removed unknown keys from translations/ja.js
- Added a missing translation
- chore: replace single quotes with double quotes in ja.js
@fu2hito fu2hito force-pushed the remove-unknownkeys-from-ja.md branch from e80dc58 to 19ce351 Compare February 27, 2025 14:50
@nikku nikku merged commit 3705499 into bpmn-io:main Feb 27, 2025
2 checks passed
@nikku
Copy link
Member

nikku commented Feb 27, 2025

Looks great, works great, thank you ⭐

@nikku
Copy link
Member

nikku commented Feb 27, 2025

Released as v2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants