Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timeout to BoxNetworkClient #484

Open
szynaka opened this issue Feb 19, 2025 · 0 comments
Open

feat: Add timeout to BoxNetworkClient #484

szynaka opened this issue Feb 19, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@szynaka
Copy link

szynaka commented Feb 19, 2025

Occasionally I have seen network requests fail to return and hang a program.

PR #479 adds an optional timeout to be used by the requests library as recommended by their documentation (https://docs.python-requests.org/en/latest/user/quickstart/#timeouts)

It would probably be better to include a default timeout of a few minutes, but that could introduce additional errors to handle. So, instead this change maintains the existing behavior if a timeout is not provided.

This issue was requested because the code in the PR is auto-generated and would need to be integrated into the code-gen engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants