-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nvidia MIG Settings #63
Conversation
a5f78d1
to
f716594
Compare
f716594
to
61baa85
Compare
61baa85
to
4a92b7e
Compare
ef6e3dc
to
7b480a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed this in depth, just flagged a couple of style issues that would be good to fix while reviewing bottlerocket-os/bottlerocket-core-kit#258
7b480a9
to
cb83a60
Compare
Fixed comments in the last force push ^ |
cb83a60
to
586e5aa
Compare
Force push fixes above comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the crate versioning comment, this lgtm!
bottlerocket-settings-models/settings-extensions/kubelet-device-plugins/src/lib.rs
Show resolved
Hide resolved
586e5aa
to
5c731ae
Compare
Force push updates the |
5c731ae
to
2fae7f8
Compare
Missed |
Issue #, if available:
Description of changes:
settings.kubelet-device-plugins.nvidia.device-partitioning-strategy
andsettings.kubelet-device-plugins.nvidia.mig.profile
in bottlerocket.Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.