Skip to content

Commit

Permalink
[#373] fix chart deployment
Browse files Browse the repository at this point in the history
Using the `.Chart.AppVersion` for image tags exposed a bug that was
introduced when we moved to opensource.  Previously we were overwriting
path dependencies in helm charts during the release process via the
`release` profile. After open-sourcing our release profile name changed
from `release` to `ossrh-release`, but we didn't update it in the
`extensions-helm` POM.  However, it was incorrect to only rewrite
dependencies during release anyway, as the chart dependencies should be
rewritten _any_ time we're deploying (including snapshots). So instead
we moved the functionality to the `ci` profile (which is also active
during release.)

Also found an issue with release-prepare introduced by #451 preventing
the version update process due to unresolved property.
  • Loading branch information
ewilkins-csi committed Nov 5, 2024
1 parent 4f8df35 commit 003f996
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion extensions/extensions-helm/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
</properties>
</profile>
<profile>
<id>release</id>
<id>ci</id>
<properties>
<overwrite.dependencies>true</overwrite.dependencies>
</properties>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
<classifier>tests</classifier>
<type>test-jar</type>
<scope>test</scope>
<version>${version.aissemble}</version>
<version>${project.version}</version>
</dependency>
<dependency>
<!-- Spark hasn't migrated to Jakarta packages yet. Will need to shade it if we want to fully migrate. -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
<classifier>tests</classifier>
<type>test-jar</type>
<scope>test</scope>
<version>${version.aissemble}</version>
<version>${project.version}</version>
</dependency>
<dependency>
<!-- Spark hasn't migrated to Jakarta packages yet. Will need to shade it if we want to fully migrate. -->
Expand Down

0 comments on commit 003f996

Please sign in to comment.