Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lower incomplete gamma functions with x = 0 #1250

Closed
wants to merge 5 commits into from

Conversation

cohomology
Copy link

In this case, the errno error handling did not work correctly, as internal functions where accidently setting it, although no
overflow happens.

Fixes #1249.

mborland and others added 5 commits October 30, 2024 09:19
In this case, the errno error handling did not work correctly,
as internal functions where accidently setting it, although no
overflow happens.

Fixes boostorg#1249.
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.84%. Comparing base (a5c0625) to head (6e5ba9a).

Files with missing lines Patch % Lines
include/boost/math/special_functions/gamma.hpp 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1250   +/-   ##
========================================
  Coverage    93.83%   93.84%           
========================================
  Files          657      658    +1     
  Lines        55244    55298   +54     
========================================
+ Hits         51840    51895   +55     
+ Misses        3404     3403    -1     
Files with missing lines Coverage Δ
test/git_issue_1249.cpp 100.00% <100.00%> (ø)
include/boost/math/special_functions/gamma.hpp 92.18% <90.90%> (-0.08%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c0625...6e5ba9a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cohomology cohomology closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong result for lower incomplete gamma function and x = 0
2 participants