-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gamma.hpp #1236
Update gamma.hpp #1236
Conversation
Missing name for Lanczos parameter in gamma_imp_final
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a (void)l
somewhere? This will cause unused parameter warnings except when printing is enabled.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1236 +/- ##
========================================
Coverage 93.83% 93.83%
========================================
Files 657 657
Lines 55244 55244
========================================
Hits 51840 51840
Misses 3404 3404
Continue to review full report in Codecov by Sentry.
|
Added the requested code inside the conditional compilation before debugging code (void)l; |
I added a commit moving it outside of the #if block since thats where it'll cause issues. Sorry if I was not sufficiently clear. |
I'm sorry I'm not familiar with that practice so placed it where as little disruption could cause. |
Next time I see this kind of issue I will do it better |
No worries. Thanks for the PR! |
Missing name for Lanczos parameter in gamma_imp_final at line 114
It caused an error when compiling at line 124
Checked on old code and the parameter has l name