Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gamma.hpp #1236

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Update gamma.hpp #1236

merged 3 commits into from
Jan 21, 2025

Conversation

kenarab
Copy link
Contributor

@kenarab kenarab commented Jan 21, 2025

Missing name for Lanczos parameter in gamma_imp_final at line 114

It caused an error when compiling at line 124

 std::cout << "tgamma_imp called with " << typeid(z).name() << " " << typeid(l).name() << std::endl;

Checked on old code and the parameter has l name

Missing name for Lanczos parameter in gamma_imp_final
Copy link
Member

@mborland mborland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a (void)l somewhere? This will cause unused parameter warnings except when printing is enabled.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.83%. Comparing base (024a4fe) to head (41790ee).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1236   +/-   ##
========================================
  Coverage    93.83%   93.83%           
========================================
  Files          657      657           
  Lines        55244    55244           
========================================
  Hits         51840    51840           
  Misses        3404     3404           
Files with missing lines Coverage Δ
include/boost/math/special_functions/gamma.hpp 92.25% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 024a4fe...41790ee. Read the comment docs.

@kenarab
Copy link
Contributor Author

kenarab commented Jan 21, 2025

Added the requested code inside the conditional compilation before debugging code

(void)l;

@mborland
Copy link
Member

Added the requested code inside the conditional compilation before debugging code

(void)l;

I added a commit moving it outside of the #if block since thats where it'll cause issues. Sorry if I was not sufficiently clear.

@kenarab
Copy link
Contributor Author

kenarab commented Jan 21, 2025

I'm sorry I'm not familiar with that practice so placed it where as little disruption could cause.

@kenarab
Copy link
Contributor Author

kenarab commented Jan 21, 2025

Next time I see this kind of issue I will do it better

@mborland
Copy link
Member

No worries. Thanks for the PR!

@mborland mborland merged commit 2f3c798 into boostorg:develop Jan 21, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants