Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVRTC Batch 6 #1182

Merged
merged 18 commits into from
Aug 19, 2024
Merged

NVRTC Batch 6 #1182

merged 18 commits into from
Aug 19, 2024

Conversation

mborland
Copy link
Member

Adds support for modf (ours is different than libcu++), trigamma, and two arg beta. This brings NVRTC support up to par with NVCC and SYCL, so this will be the last NVRTC only PR. Moving forward the PRs will add unified support.

Adds new workaround header <boost/math/tools/cstdint.hpp> to provide fixed width type definitions and defines boost::math::size_t to unsigned long on CUDA platforms because that type is missing. NVIDIA has been producing only 64-bit devices since 2012 so this size type is a safe assumption.

Completed CI runs can be found: cppalliance/cuda-math#15

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 91.93548% with 5 lines in your changes missing coverage. Please review.

Project coverage is 94.06%. Comparing base (54e5acf) to head (1add05b).
Report is 19 commits behind head on develop.

Files Patch % Lines
include/boost/math/special_functions/lanczos.hpp 80.76% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1182      +/-   ##
===========================================
- Coverage    94.08%   94.06%   -0.02%     
===========================================
  Files          780      780              
  Lines        65796    65796              
===========================================
- Hits         61903    61891      -12     
- Misses        3893     3905      +12     
Files Coverage Δ
include/boost/math/policies/error_handling.hpp 83.73% <ø> (ø)
include/boost/math/policies/policy.hpp 95.83% <100.00%> (ø)
include/boost/math/special_functions/beta.hpp 100.00% <100.00%> (ø)
include/boost/math/special_functions/gamma.hpp 91.75% <ø> (ø)
include/boost/math/special_functions/modf.hpp 100.00% <ø> (ø)
include/boost/math/special_functions/pow.hpp 100.00% <100.00%> (ø)
include/boost/math/special_functions/trigamma.hpp 97.69% <100.00%> (ø)
include/boost/math/tools/fraction.hpp 91.04% <100.00%> (ø)
include/boost/math/tools/rational.hpp 100.00% <100.00%> (ø)
include/boost/math/tools/roots.hpp 86.79% <ø> (ø)
... and 1 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54e5acf...1add05b. Read the comment docs.

@mborland mborland merged commit 1d40454 into develop Aug 19, 2024
77 of 79 checks passed
@mborland mborland deleted the NVRTC_6 branch August 19, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant