Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get something of octonion tested #1087

Merged
merged 7 commits into from
Feb 12, 2024
Merged

Get something of octonion tested #1087

merged 7 commits into from
Feb 12, 2024

Conversation

ckormanyos
Copy link
Member

No description provided.

@ckormanyos
Copy link
Member Author

ckormanyos commented Feb 12, 2024

So what I'm finding out is that octonions are fascination. I believe there is a relation to them and order-2 Lie groups. Long on my TODO list and I have no clue about them.

We have been doing essentially no actual testing of these.

Anyway, the original file octonion_test.cpp in my opinion has more of an exemplary nature. It is described in Math's docs also as such. We can annotate it and potentially rename it as an example.

For actual testing, ... I have in the branch started a new file called octonion_test_simple.cpp. It is reminiscent of the original file but its focus will be on testing the actual octonion implementation more clearly and achieving coverage.

I need to study up and get more test data. Python does a lot of this stuff. I'd like some data points for a few basic elementary functions too like exp(), etc. So this will be a cool little hobby...

Cc: @jzmaddock and @mborland and @NAThompson

@NAThompson
Copy link
Collaborator

@ckormanyos : Wasn't there a discussion about deprecating that file since there is now a qvm library in boost?

@ckormanyos
Copy link
Member Author

ckormanyos commented Feb 12, 2024

Wasn't there a discussion about deprecating that file since there is now a qvm library in boost?

I'd like that. It seems like legacy code with old style.

I could in this PR:

  • Formulate a deprecation notice (till 1.86).
  • Does this mean deprecate octonion and quaternion? Or just octonion?
  • Eliminate negative influence from this stuff in CodeCov.

I would need help with the docs upon actual deprecation. But gone seems good on this one.

I just need all-party agreement.

Cc: @jzmaddock and @mborland abd @NAThompson

@mborland
Copy link
Member

I don't think QVM supports Octonion so we shouldn't deprecate this without replacement. We should add testing because it's already here.

@ckormanyos
Copy link
Member Author

I don't think QVM supports Octonion so we shouldn't deprecate this without replacement. We should add testing because it's already here.

I was afraid you'd say that. GSoC 2030 make octonion great again

@ckormanyos
Copy link
Member Author

Ok this is better than it was.

  • But we still need a couple hundred lines of octonian coverage.
  • I also disabled lcovfor Input-Streaming of octonians.

We can sort this octonian thing out in a few later rounds.

For now I'll merge, as it's better than earlier.

@ckormanyos ckormanyos merged commit 380a1cf into develop Feb 12, 2024
67 of 68 checks passed
@ckormanyos ckormanyos deleted the try_testing_octonion branch February 12, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants