-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get something of octonion tested #1087
Conversation
So what I'm finding out is that octonions are fascination. I believe there is a relation to them and order-2 Lie groups. Long on my TODO list and I have no clue about them. We have been doing essentially no actual testing of these. Anyway, the original file octonion_test.cpp in my opinion has more of an exemplary nature. It is described in Math's docs also as such. We can annotate it and potentially rename it as an example. For actual testing, ... I have in the branch started a new file called octonion_test_simple.cpp. It is reminiscent of the original file but its focus will be on testing the actual octonion implementation more clearly and achieving coverage. I need to study up and get more test data. Python does a lot of this stuff. I'd like some data points for a few basic elementary functions too like Cc: @jzmaddock and @mborland and @NAThompson |
@ckormanyos : Wasn't there a discussion about deprecating that file since there is now a qvm library in boost? |
I'd like that. It seems like legacy code with old style. I could in this PR:
I would need help with the docs upon actual deprecation. But gone seems good on this one. I just need all-party agreement. Cc: @jzmaddock and @mborland abd @NAThompson |
I don't think QVM supports Octonion so we shouldn't deprecate this without replacement. We should add testing because it's already here. |
I was afraid you'd say that. GSoC 2030 make octonion great again |
Ok this is better than it was.
We can sort this octonian thing out in a few later rounds. For now I'll merge, as it's better than earlier. |
No description provided.