Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMA-ES #1074

Merged
merged 1 commit into from
Feb 9, 2024
Merged

CMA-ES #1074

merged 1 commit into from
Feb 9, 2024

Conversation

NAThompson
Copy link
Collaborator

No description provided.

@NAThompson NAThompson force-pushed the cma_es branch 5 times, most recently from 544e33f to d1de875 Compare January 27, 2024 19:26
@NAThompson NAThompson changed the title [CI SKIP][ci skip] CMA-ES CMA-ES Jan 27, 2024
@NAThompson NAThompson force-pushed the cma_es branch 3 times, most recently from 3977f82 to 3dce455 Compare January 30, 2024 23:45
@NAThompson NAThompson force-pushed the cma_es branch 10 times, most recently from f24feaf to 8b51e94 Compare February 8, 2024 19:45
@NAThompson NAThompson marked this pull request as ready for review February 8, 2024 19:53
@NAThompson NAThompson force-pushed the cma_es branch 2 times, most recently from fbfbdb7 to 186928f Compare February 8, 2024 20:25
@NAThompson
Copy link
Collaborator Author

@mborland , @jzmaddock : After great and agonizing pain I believe I've got this working.

Let me know if you're interested in this and want time to review, otherwise I'll probably merge in a couple days. . .

Copy link
Member

@mborland mborland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having read the paper here are my trivial comments. The only other thing is there's like zero white space which makes it kind of hard to read. Maybe empty lines before and after outer loops, ifs, equation references, etc would improve readability.

Comment on lines +7 to +8
#if __APPLE__ || __linux__
#include <signal.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be every POSIX system right? You could #if __has_include(<unistd.h>) which is a requirement of every POSIX system.

include/boost/math/optimization/cma_es.hpp Outdated Show resolved Hide resolved
include/boost/math/optimization/cma_es.hpp Outdated Show resolved Hide resolved
@NAThompson NAThompson merged commit 222d266 into develop Feb 9, 2024
66 of 68 checks passed
@NAThompson NAThompson deleted the cma_es branch February 9, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants