Fix off-by-one error in parser buffer size #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a value with the maximum number of digits the last digit will be truncated and the exponent increased instead. This change allows to parse e.g. `<UINT64_MAX>e0` correctly.
Flamefire
force-pushed
the
off-by-one
branch
from
679ccfa to
73eb4f8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #243 +/- ##
===========================================
+ Coverage 94.76% 94.77% +0.01%
===========================================
Files 69 69
Lines 9031 9051 +20
===========================================
+ Hits 8558 8578 +20
Misses 473 473
Continue to review full report in Codecov by Sentry.
|
This was referenced Dec 28, 2024
mborland
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a value with the maximum number of digits the last digit will be truncated and the exponent increased instead.
This change allows to parse e.g.
<UINT64_MAX>[e0]correctly.