Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configured load tests for azure #1057

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rdiaz82
Copy link
Contributor

@rdiaz82 rdiaz82 commented Apr 12, 2022

Description

In this PR we are configuring the load tests for the Azure provider. Basically we have reverted serverless framework to the old version because it is not compatible with Serverless Artillery and then we have had to increase the timeout in the tests and adapted the load to be manageable by Azure. We achieve 200 requests/sec during 10 sec followed by 400 req/sec for 10sec.

Changes

  • Test configuration to be similar to other integration tests
  • modified timeouts in tests
  • Adapted the load to Azure

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

@rdiaz82 rdiaz82 requested a review from a team April 12, 2022 13:22
Copy link
Member

@javiertoledo javiertoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very useful!

Comment on lines 48 to 49
"serverless": "1.83.3",
"serverless-artillery": "0.5.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So bad we're still relying on this, as this package has been abandoned. Just as a reminder for ourselves, there's a pending issue related to finding an alternative or building this capability within Booster #934

@@ -86,7 +86,8 @@
"integration/azure-deploy": "TESTED_PROVIDER=AZURE BOOSTER_ENV=azure mocha --forbid-only --exit --config \"integration/provider-specific/azure/deployment/.mocharc.yml\" \"integration/provider-specific/azure/deployment/**/*.integration.ts\"",
"integration/azure-nuke": "TESTED_PROVIDER=AZURE BOOSTER_ENV=azure mocha --forbid-only --exit --config \"integration/provider-specific/azure/nuke/.mocharc.yml\" \"integration/provider-specific/azure/nuke/**/*.integration.ts\"",
"integration/azure-end-to-end": "TESTED_PROVIDER=AZURE BOOSTER_ENV=azure mocha --forbid-only --exit --config \"integration/provider-unaware/end-to-end/.mocharc.yml\" \"integration/provider-unaware/end-to-end/**/*.integration.ts\"",
"integration/azure-func": "TESTED_PROVIDER=AZURE BOOSTER_ENV=azure mocha --forbid-only --exit --config \"integration/provider-unaware/end-to-end/.mocharc.yml\" \"integration/provider-unaware/functionality/**/*.integration.ts\""
"integration/azure-func": "TESTED_PROVIDER=AZURE BOOSTER_ENV=azure mocha --forbid-only --exit --config \"integration/provider-unaware/end-to-end/.mocharc.yml\" \"integration/provider-unaware/functionality/**/*.integration.ts\"",
"integration/azure-load": "TESTED_PROVIDER=AZURE AWS_SDK_LOAD_CONFIG=true BOOSTER_ENV=azure mocha --forbid-only --exit --config \"integration/provider-unaware/load/.mocharc.yml\" \"integration/provider-unaware/load/**/*.load.ts\""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this call on the "integration/azure" script (line 85)?

…_test_azure

# Conflicts:
#	package-lock.json
#	packages/framework-integration-tests/package.json
@ghost
Copy link

ghost commented Mar 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@javiertoledo
Copy link
Member

/integration sha=792b5d6bf320704a207d5acc1ef92b1cf2284cac

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

❌ Oh no! Integration tests have failed

@javiertoledo
Copy link
Member

/integration sha=f7a32b7d18aaa1b7d0c961433089a3edcd42fb26

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

❌ Oh no! Integration tests have failed

…_test_azure

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
@javiertoledo
Copy link
Member

/integration sha=3e61b829586e58a7c565b7c83ed144ee0d7fdd6a

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

⌛ Integration tests are running...

Check their status here 👈

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

❌ Oh no! Integration tests have failed

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

❌ Oh no! Integration tests have failed

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

❌ Oh no! Integration tests have failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants