Fix clang tidy warnings #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 thank you @tobiasleibner |
Since the CMAKE_CXX_STANDARD is only a minimum version and does not enforce C++17 usage, these pipelines use C++20 anyway (since that is the default in most compilers today).
tobiasleibner
force-pushed
the
fix_clang_tidy_warnings
branch
from
266a78a to
2063107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When working on #656, I got a lot of clang-tidy warnings from clangd.
Solution:
Silence some warnings in the
.clang-tidyconfig file or by usingNOLINTs, and fix most others.This PR is based on #656 to fix the CI issues, so no need to review yet, let us merge #656 in first.