Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password rehash #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Password rehash #63

wants to merge 3 commits into from

Conversation

alexm
Copy link

@alexm alexm commented Oct 3, 2015

Add a new feature that will rehash passwords with salt using EKS Blowfish when a user changes their password. It maintains backwards compatibility with current password digest and it supports other crypt(3) digests too.

@alexm
Copy link
Author

alexm commented Oct 3, 2015

FWIW I already tested Crypt::Eksblowfish::Bcrypt in spectre and it works fine with cost 10. Find the tests in ~alexm/src.

@alexm
Copy link
Author

alexm commented Nov 13, 2015

  • Has anybody had the chance to take a look at these changes?
  • What do you think about them?
  • Is there any concern for merging them into production?

@labster
Copy link

labster commented Jul 6, 2019

It's somewhat terrifying to me that this hasn't been merged, or something like it. 2019 is way too late to be using MD5. I mean, I'd have implemented it with Authen::Passphrase, but I guess that has more dependencies.

@eseyman
Copy link
Collaborator

eseyman commented Jul 11, 2019

If someone fixes the conflicts, I'll agree to review it. Although, like @labster, I'm much more in favour of using Authen-Passphrase than Crypt::Eksblowfish::Bcrypt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants