Skip to content

Commit

Permalink
https://github.com/bonfire-networks/bonfire-app/issues/900
Browse files Browse the repository at this point in the history
  • Loading branch information
mayel committed Jan 6, 2025
1 parent 3204701 commit fef4348
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion lib/modularity/declare_helpers.ex
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ defmodule Bonfire.Common.Modularity.DeclareHelpers do
module: module,
app: app(module),
href: opts[:href] || Bonfire.Common.URIs.path(module),
type: :link
type: :link,
sub_widgets:
Enum.map(opts[:sub_links] || [], fn {name, opts} -> generate_link(name, module, opts) end)
})
end

Expand Down
2 changes: 1 addition & 1 deletion lib/modularity/extension_diff.ex
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ defmodule Bonfire.Common.Extensions.Diff do
# end

def tmp_path(prefix) do
Path.join([System.tmp_dir!(), prefix <> Text.unique_string()])
Path.join([System.tmp_dir!(), "bonfire_repos", prefix <> Text.unique_string()])
end

def root, do: Bonfire.Common.Config.get(:root_path)
Expand Down
2 changes: 2 additions & 0 deletions lib/utils.ex
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ defmodule Bonfire.Common.Utils do
Various very commonly used utility functions for the Bonfire application.
This module should contain only a few generic and/or heavily-used functions, and any other functions should be in more specific modules (or in other extensions altogether) for e.g.:
- `Bonfire.Common.Enums` for functions around maps, structs, keyword lists, and the like
- `Bonfire.Common.Types` for object types
- `Bonfire.Common.URIs` and `Linkify` for URI handling
Expand All @@ -22,6 +23,7 @@ defmodule Bonfire.Common.Utils do
- `Bonfire.Common.PubSub` for pub/sub
We may also want to consider reusing functions from existing utils libraries when possible and contributing missing ones there, for example:
- https://hexdocs.pm/moar/readme.html
- https://hexdocs.pm/bunch/api-reference.html
- https://hexdocs.pm/swiss/api-reference.html
Expand Down

0 comments on commit fef4348

Please sign in to comment.