Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test CI #856

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Update test CI #856

merged 1 commit into from
Feb 20, 2024

Conversation

fishinthecalculator
Copy link

No description provided.

@mayel
Copy link
Member

mayel commented Feb 18, 2024

Thanks for this, looks great! Only wondering about any pros/cons between manually installing docker vs using native container support like:

services:
      postgres:
        image: postgis/postgis:12-3.3-alpine

@fishinthecalculator
Copy link
Author

fishinthecalculator commented Feb 18, 2024

Thanks for this, looks great! Only wondering about any pros/cons between manually installing docker vs using native container support like:

services:
      postgres:
        image: postgis/postgis:12-3.3-alpine

I don't have a clear opinion on this topic. The rationale for having commands run from the justfile is that imho CI should run as close as possible to what we run in the CLI upon developing. This way as soon as the justfile is broken somehow CI also breaks and it also avoids duplicating implementation between the CI job and the development environment setup. If you have a different opinion I'd love to hear it!

EDIT: The real solution imo would be to switch to nix for everything but it is a substantial investment and i don't think it is worth at this point

@fishinthecalculator fishinthecalculator marked this pull request as ready for review February 19, 2024 19:32
@fishinthecalculator fishinthecalculator marked this pull request as draft February 19, 2024 19:35
@mayel
Copy link
Member

mayel commented Feb 19, 2024

@fishinthecalculator it may be relevant that git-publish.sh is used to push regular commits, not only when releasing a new version, so not sure if creating the tag there makes sense?

@fishinthecalculator
Copy link
Author

@mayel thank you for the heads up, i had some rethinking about how to proceed. i'm starting to think that this MR should just be split between the test and the release part. I didn't remember about the contrib-release command you told me about until today and i wanted to start a discussion about how to stabilize the main branch

OT: is there some chat or some synchronous media where you hang out to talk about bonfire if I have some quick technical question? should I use https://campground.bonfire.cafe ?

@mayel
Copy link
Member

mayel commented Feb 19, 2024

sounds good! there's https://matrix.to/#/%23bonfire-tech%3Amatrix.org

@mayel
Copy link
Member

mayel commented Feb 20, 2024

Should we merge this one and then go from there?

@fishinthecalculator
Copy link
Author

Yes I agree

@fishinthecalculator fishinthecalculator marked this pull request as ready for review February 20, 2024 19:01
@mayel mayel merged commit 5285461 into bonfire-networks:main Feb 20, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants