-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load nfc2klipper cfg from home directory #10
base: main
Are you sure you want to change the base?
Conversation
I agree, its better to keep a separate file so pulling changes won't risk unnecessary conflicts. Maybe it is better to use |
sounds good. creating that directory and placing the file sounds like something an install script should do, shall i add one? |
Yes, please add one. |
the other option is have a nfc2klipper-config.json5.default file in the repo, then add nfc2klipper-config.json5 to the .gitignore file. This way we can copy the default to nfc2klipper-config.json5 and make our own changes and git ignores them. But yes using ~/.config is also an option. The advantage of the .default copy is people know what options can be in the config. |
I implemented toml support (kind of like klipper/moonraker's config files) yesterday and then it reads the config file from ~/.config/nfc2klipper/nfc2clipper.cfg or ~/nfc2klipper.cfg. See the There is no automatic upgrade from the json5 file, but if it doesn't find a config file it copies the included config file. |
nice! could you turn the branch into a pull request so it's easier to review? |
I prefer not to modify the config file in the repository (making it harder to git pull and solve conflicts) so I suggest to place the config in the home directory instead.