Support (more) empty array dim fetch during assignment

Fixes #760
bobthecow · Apr 24, 2023 · 4f567c5 · 4f567c5
1 parent 5350ce0
commit 4f567c5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/CodeCleaner/EmptyArrayDimFetchPass.php b/src/CodeCleaner/EmptyArrayDimFetchPass.php
@@ -50,6 +50,11 @@ public function enterNode(Node $node)
             $this->theseOnesAreFine[] = $node->expr;
         } elseif ($node instanceof Foreach_ && $node->valueVar instanceof ArrayDimFetch) {
             $this->theseOnesAreFine[] = $node->valueVar;
+        } elseif ($node instanceof ArrayDimFetch && $node->var instanceof ArrayDimFetch) {
+            // $a[]['b'] = 'c'
+            if (\in_array($node, $this->theseOnesAreFine)) {
+                $this->theseOnesAreFine[] = $node->var;
+            }
         }
 
         if ($node instanceof ArrayDimFetch && $node->dim === null) {

diff --git a/test/CodeCleaner/EmptyArrayDimFetchPassTest.php b/test/CodeCleaner/EmptyArrayDimFetchPassTest.php
@@ -62,6 +62,7 @@ public function validStatements()
             ['$foo->{$bar}[] = 1'],
             ['foreach ($bar as $foo[]) {}'],
             ['$bar = &$foo[]'],
+            ['$foo[]["bar"] = "baz"'],
         ];
 
         return $data;