Merge pull request #455 from alexgao001/fix-maintainnece-addr

fix: return err when maintenance addr is not provided
bnb-chain · Sep 5, 2023 · fe1870a · fe1870a
2 parents 7f5eb40 + f4ab199
commit fe1870a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/x/sp/keeper/msg_server.go b/x/sp/keeper/msg_server.go
@@ -47,7 +47,10 @@ func (k msgServer) CreateStorageProvider(goCtx context.Context, msg *types.MsgCr
 	sealAcc := sdk.MustAccAddressFromHex(msg.SealAddress)
 	approvalAcc := sdk.MustAccAddressFromHex(msg.ApprovalAddress)
 	gcAcc := sdk.MustAccAddressFromHex(msg.GcAddress)
-	maintenanceAcc := sdk.MustAccAddressFromHex(msg.MaintenanceAddress)
+	maintenanceAcc, err := sdk.AccAddressFromHexUnsafe(msg.MaintenanceAddress)
+	if err != nil {
+		return nil, err
+	}
 
 	signers := msg.GetSigners()
 	if ctx.BlockHeight() == 0 {