Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make valid_status constraint optional #205

Merged
merged 1 commit into from
Feb 14, 2025
+4 −2
Merged

Make valid_status constraint optional #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@

### 0.10.1-dev

* If the constraint `valid_status` is omitted in the configuration file of `lobster-report`,
then no status check is performed.

* `lobster-html-report` gives consistent error message if the input file does not exist,
even if the user specified no value. In that case the tool tries to open the file
called `lobster.report` in the current working directory as input, and it gives the
Expand All @@ -13,7 +16,6 @@
* `lobster-codebeamer` used to append `/cb` to the `root` parameter in config file
and now the user explicitly needs to add it while specifying the `root`.


### 0.10.0

* `lobster-html-report` adds actual git commit hashes to the source in the HTML report.
Expand Down
2 changes: 1 addition & 1 deletion lobster/items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def to_json(self):

def perform_source_checks(self, source_info):
assert isinstance(source_info, dict)
if source_info["valid_status"]:
if source_info.get("valid_status"):
if self.status not in source_info["valid_status"]:
self.error("status is %s, expected %s" %
(self.status,
Expand Down
Loading