Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make valid_status constraint optional #205

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Make valid_status constraint optional #205

merged 1 commit into from
Feb 14, 2025

Conversation

phiwuu
Copy link
Member

@phiwuu phiwuu commented Feb 13, 2025

If the constraint valid_status is omitted in the configuration file of lobster-report, then no check is performed.

Issue #190

@phiwuu phiwuu self-assigned this Feb 13, 2025
@phiwuu phiwuu added the lobster-core Affects core LOBSTER tools label Feb 13, 2025
@phiwuu phiwuu force-pushed the bugfix/valid-status branch 2 times, most recently from 6fd6c5f to 9d67645 Compare February 13, 2025 14:11
@phiwuu phiwuu marked this pull request as ready for review February 14, 2025 08:38
@phiwuu phiwuu requested a review from a team as a code owner February 14, 2025 08:38
If the constraint `valid_status` is omitted in the configuration file of `lobster-report`,
then no status check is performed.

Issue #190
@phiwuu phiwuu force-pushed the bugfix/valid-status branch from 9d67645 to b224dcb Compare February 14, 2025 08:42
@kedarnn kedarnn merged commit 4cd62e2 into main Feb 14, 2025
25 checks passed
@kedarnn kedarnn deleted the bugfix/valid-status branch February 14, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lobster-core Affects core LOBSTER tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants