Fix unit test folder structure #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugdhadhole1
added
the
internal
The folder "core" is eliminated and unit tests for report tools now exist in the "tests-unit" folder
mugdhadhole1
force-pushed
the
internal/fix-unit-test-folder-structure
branch
from
4827b58 to
08afa07
Compare
phiwuu
reviewed
Feb 12, 2025
| @@ -161,8 +161,8 @@ code.lobster-%: | |||
| lobster-python --out code.lobster lobster/tools/$(TOOL_PATH) | |||
|
|
|||
| unit-tests.lobster-%: | |||
| $(eval TOOL_PATH := $(subst -,/,$*)) | |||
| lobster-python --activity --out unit-tests.lobster tests-unit/lobster-$(TOOL_PATH) | |||
| $(eval TOOL_NAME := $(subst _,-,$(notdir $(TOOL_PATH)))) | |||
There was a problem hiding this comment.
Should it be TOOL_NAME instead of TOOL_PATH everywhere?
Suggested change
| $(eval TOOL_NAME := $(subst _,-,$(notdir $(TOOL_PATH)))) | |
| $(eval TOOL_NAME := $(subst _,-,$(notdir $(TOOL_NAME)))) |
There was a problem hiding this comment.
The TOOL_PATH variable contains the path of tools from lobster/tools/core folder as
core/ci_report
core/html_report
core/online_report
core/report
and it tries to find the tool in tests-unit folder as
core/lobster-ci_report
core/lobster-html_report
core/lobster-online_report
core/lobster-report
hence, this affects tracing reports, reports do not get generated.
So, I fetch the path from TOOL_PATH and then eliminate the "core/" part and replace "_" with "-"
The code gives the TOOL_NAME as
lobster-ci-report
lobster-html-report
lobster-online-report
lobster-report
and tracing reports then get generated successfully
phiwuu
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented fix in the folder structure for
tests-unitfolder.Eliminated
corefolder.Moved unit tests from
tests-unit/coretotests-unitfolder.