Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix system test rbt-report-input-duplicate-definition #183

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

phiwuu
Copy link
Member

@phiwuu phiwuu commented Jan 23, 2025

  • The *.lobster input files were missing for this test.
  • The test was located at a wrong location, where the test was not executed at all.

Furthermore, changed the order of assertions in the system test framework:
First, the STDOUT is compared against its expected value, then STDERR, and only then
is the exit code compared. This makes debugging failing tests easier.

@phiwuu phiwuu self-assigned this Jan 23, 2025
@phiwuu phiwuu added the internal Affects the CI, tests or refactorings only, not relevant to the end-user label Jan 23, 2025
@phiwuu phiwuu force-pushed the internal/fix-lobster-report-tests branch 3 times, most recently from f0d4758 to 4613a80 Compare January 23, 2025 20:41
@phiwuu phiwuu marked this pull request as ready for review January 23, 2025 20:46
@phiwuu phiwuu requested a review from a team as a code owner January 23, 2025 20:46
@phiwuu phiwuu requested a review from mugdhadhole1 January 23, 2025 20:46
@phiwuu phiwuu force-pushed the internal/fix-lobster-report-tests branch from 4613a80 to 7f9a723 Compare January 23, 2025 20:49
@phiwuu phiwuu enabled auto-merge (squash) January 23, 2025 21:00
- The `*.lobster` input files were missing for this test.
- The test was located at a wrong location, where the test was not executed at all.

Furthermore, changed the order of assertions in the system test framework:
First, the STDOUT is compared against its expected value, then STDERR, and only then
is the exit code compared. This makes debugging failing tests easier.
@phiwuu phiwuu force-pushed the internal/fix-lobster-report-tests branch from 7f9a723 to 278ab32 Compare January 23, 2025 21:12
@phiwuu phiwuu merged commit 7cb42ab into main Jan 24, 2025
25 checks passed
@phiwuu phiwuu deleted the internal/fix-lobster-report-tests branch January 24, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Affects the CI, tests or refactorings only, not relevant to the end-user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants