Add "basic" integration test clear output #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mugdhadhole1
force-pushed
the
test/basic-integration-test-clear-output
branch
5 times, most recently
from
84fcd33 to
de8dcdd
Compare
phiwuu
previously approved these changes
Jan 28, 2025
phiwuu
reviewed
Jan 28, 2025
| @lobster-ci-report | tee ci_report.reference_output | ||
|
|
||
| @bash -c "lobster-report && echo '✅ lobster-report succeeded!' || { echo '❌ ERROR: lobster-report failed!'; exit 1; }" | ||
|
|
There was a problem hiding this comment.
Recommendation: remove empty lines
Clear output of what went wrong, if any tool in "basic" integration test fails
mugdhadhole1
force-pushed
the
test/basic-integration-test-clear-output
branch
from
82d2454 to
75e79a3
Compare
kedarnn
reviewed
Jan 28, 2025
Comment on lines
-22
to
-27
| @if diff report.lobster $(REFERENCE_OUTPUT); then \ | ||
| echo "Files are identical"; \ | ||
| else \ | ||
| echo "Files are different"; \ | ||
| exit 1; \ | ||
| fi |
There was a problem hiding this comment.
Please handle this in the new error handling block.
mugdhadhole1
force-pushed
the
test/basic-integration-test-clear-output
branch
from
75e79a3 to
5a17d8f
Compare
kedarnn
approved these changes
Jan 29, 2025
phiwuu
added
the
internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear output of what went wrong, if any tool in "basic" integration test fails