Split LOBSTER_Tool.process_commandline_options
#173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phiwuu
added
the
internal
phiwuu
force-pushed
the
internal/lobster-json-refactoring
branch
4 times, most recently
from
760b66d to
4416961
Compare
phiwuu
force-pushed
the
internal/lobster-json-refactoring
branch
from
4416961 to
949979b
Compare
auto-merge was automatically disabled
January 13, 2025 12:42
Pull request was converted to draft
phiwuu
force-pushed
the
internal/lobster-json-refactoring
branch
from
73e69e7 to
dc37fdb
Compare
phiwuu
force-pushed
the
internal/lobster-json-refactoring
branch
4 times, most recently
from
5695d72 to
32d1d43
Compare
phiwuu
force-pushed
the
internal/lobster-json-refactoring
branch
from
32d1d43 to
1a3f05f
Compare
phiwuu
commented
Jan 28, 2025
phiwuu
force-pushed
the
internal/lobster-json-refactoring
branch
6 times, most recently
from
72ec6ce to
da55168
Compare
Previously the function `LOBSTER_Tool.process_commandline_options` did two things: It processed - the common command line options - and the tool specific command line options. The code has been refactored such that there are dedicated functions for each of these two steps. This increases readability of the code. Type hints have been added to some functions. The implementation of the method `LOBSTER_Per_File_Tool.process` has been replaced by a single `pass`, because it is abstract.
phiwuu
force-pushed
the
internal/lobster-json-refactoring
branch
from
da55168 to
9b7b490
Compare
kedarnn
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the function
LOBSTER_Tool.process_commandline_optionsdid two things:
It processed
The code has been refactored such that there are dedicated
functions for each of these two steps.
This increases readability of the code.
Type hints have been added to some functions.
The implementation of the method
LOBSTER_Per_File_Tool.processhas beenreplaced by a single
pass, because it is abstract.