Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/speed: avoid unnecessary collection #60

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor/speed: avoid unnecessary collection #60

wants to merge 5 commits into from

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Apr 7, 2021

Ref #56

@drahnr
Copy link
Contributor Author

drahnr commented Apr 7, 2021

billyrieger/bimap-rs#27 needs a fix so fnv can be used to speedup lookups given all the tiny key sizes.

@drahnr
Copy link
Contributor Author

drahnr commented Apr 7, 2021

Pending merge, to speed this up: billyrieger/bimap-rs#28

@drahnr drahnr force-pushed the bernhard-perf branch 2 times, most recently from f179a7c to 03be1c5 Compare April 7, 2021 15:14
@billyrieger
Copy link

@drahnr You should be able to remove the patched bimap source as v0.6.1 includes your changes to the serde implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drahnr @billyrieger