Grammar check fails

[dvwright]

Issue:
Grammatically incorrect english sentence is not identified

sentence = 'Make sure to include you phone number.'

Received result:
Make sure to include you phone number.

Expected result:
Make sure to include your phone number.

Version:
nlprule-0.5.3

To recreate:

from nlprule import Tokenizer, Rules

tokenizer = Tokenizer.load("en")
rules = Rules.load("en", tokenizer)

content = 'Make sure to include you phone number.'
fixed = rules.correct(content)

if fixed == content:
    print('Grammar passed')
else:
    print('Grammar failed')

# returns: Grammar passed

Result on LanguageTool

[dvwright]

Here is another sentence which Language tool identifies four issues but no issues are found by nlprule, "Doesnt it mean theyre youre friends"

[bminixhofer]

Hi, thanks for the issue. There are two things here:

• nlprule currently does not do spellchecking, but it is on the Roadmap (Add spellchecking #2, see implementation Add spellchecking #51). 3 / 4 errors in your second sentence are due to spelling.
• nlprule does currently not do n-gram based correction (https://dev.languagetool.org/finding-errors-using-n-gram-data) since it would make the binaries prohibitively large.

That leaves one error in your second sentence (with "means") but since this is a false positive by LT anyway I don't think its necessary to investigate further. There are some rules from LT which are not implemented in nlprule (see stats in the README).

[bminixhofer]

Let me know if there's any other mismatches not explained by the points above (point (1) is usually the case if LT writes "... seems less likely than...").