Merge pull request #94 from bmf-san/fix/tx-rollback

Fix transaction rollback
bmf-san · Jun 19, 2023 · 634a379 · 634a379
2 parents 2d5ffe3 + c85e0b5
commit 634a379
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 7 deletions.
diff --git a/app/interfaces/controller/auth_test.go b/app/interfaces/controller/auth_test.go
diff --git a/app/interfaces/repository/category.go b/app/interfaces/repository/category.go
@@ -190,6 +190,7 @@ func (cr *Category) Save(req request.StoreCategory) (int, error) {
 			(?, ?, ?)
 	`, req.Name, now, now)
 	if err != nil {
+		_ = tx.Rollback()
 		return 0, err
 	}
 
@@ -253,6 +254,7 @@ func (cr *Category) DeleteByID(id int) (int, error) {
 	var count int
 	err = row.Scan(&count)
 	if err != nil {
+		_ = tx.Rollback()
 		return 0, nil
 	}
 

diff --git a/app/interfaces/repository/comment.go b/app/interfaces/repository/comment.go
@@ -145,6 +145,7 @@ func (cr *Comment) FindByID(id int) (domain.Comment, error) {
 func (cr *Comment) Save(req request.StoreComment) (int, error) {
 	tx, err := cr.ConnMySQL.Begin()
 	if err != nil {
+		_ = tx.Rollback()
 		return 0, err
 	}
 
@@ -178,6 +179,7 @@ func (cr *Comment) Save(req request.StoreComment) (int, error) {
 func (cr *Comment) SaveStatusByID(req request.UpdateCommentStatus) error {
 	tx, err := cr.ConnMySQL.Begin()
 	if err != nil {
+		_ = tx.Rollback()
 		return err
 	}
 

diff --git a/app/interfaces/repository/post.go b/app/interfaces/repository/post.go
@@ -1706,6 +1706,7 @@ func (pr *Post) FindByID(id int) (domain.Post, error) {
 func (pr *Post) Save(req request.StorePost) (int, error) {
 	tx, err := pr.ConnMySQL.Begin()
 	if err != nil {
+		_ = tx.Rollback()
 		return 0, err
 	}
 
@@ -1750,6 +1751,7 @@ func (pr *Post) Save(req request.StorePost) (int, error) {
 
 	_, err = tx.Exec(stmt, vArgs...)
 	if err != nil {
+		_ = tx.Rollback()
 		return 0, err
 	}
 
@@ -1764,6 +1766,7 @@ func (pr *Post) Save(req request.StorePost) (int, error) {
 func (pr *Post) SaveByID(req request.UpdatePost) error {
 	tx, err := pr.ConnMySQL.Begin()
 	if err != nil {
+		_ = tx.Rollback()
 		return err
 	}
 
@@ -1816,6 +1819,7 @@ func (pr *Post) SaveByID(req request.UpdatePost) error {
 
 	_, err = tx.Exec(stmt, vArgs...)
 	if err != nil {
+		_ = tx.Rollback()
 		return err
 	}
 
@@ -1840,12 +1844,14 @@ func (pr *Post) DeleteByID(id int) (int, error) {
 	`, id)
 
 	if err != nil {
+		_ = tx.Rollback()
 		return 0, err
 	}
 
 	var count int
 	err = row.Scan(&count)
 	if err != nil {
+		_ = tx.Rollback()
 		return 0, err
 	}
 

diff --git a/app/interfaces/repository/tag.go b/app/interfaces/repository/tag.go
@@ -178,6 +178,7 @@ func (tr *Tag) FindByName(name string) (domain.Tag, error) {
 func (tr *Tag) Save(req request.StoreTag) (int, error) {
 	tx, err := tr.ConnMySQL.Begin()
 	if err != nil {
+		_ = tx.Rollback()
 		return 0, err
 	}
 
@@ -211,6 +212,7 @@ func (tr *Tag) Save(req request.StoreTag) (int, error) {
 func (tr *Tag) SaveByID(req request.UpdateTag) error {
 	tx, err := tr.ConnMySQL.Begin()
 	if err != nil {
+		_ = tx.Rollback()
 		return err
 	}
 
@@ -249,6 +251,7 @@ func (tr *Tag) DeleteByID(id int) (int, error) {
 	`, id)
 
 	if err != nil {
+		_ = tx.Rollback()
 		return 0, err
 	}