Support sundials v7 #187
Merged
Support sundials v7 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUNDIALS v7 changed all the error handling code to make it consistent. This means we can refactor the error handling code to be in one central location, with only minor modifications needed.
There are now some shared base classes, which should start the process of reducing code duplication, hopefully making the code more maintainable and ensuing fixes do not need to be made in multiple places.
This should make it more obvious what is being imported, and unused imports are easier to track. This should hopefully also mean we can be more specific about what goes in the pxd files, and hopefully reduce churn on new SUNDIALS updates.
|
Possibly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #161 and #178.
Mainly this replaces SUNDIALS v6 support with v7 support, but the new error common handling in v7 has meant that I could do some additional refactoring in the error handling and some duplicate code has been removed.
I've also done some clean up of the imports, none of the pyx files should have
import *(most of the pxd files still do, and that clean up something worth doing).