Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VendorConfigManager implementations for dell, supermicro and asrockrack #12

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

splaspood
Copy link
Collaborator

@splaspood splaspood commented Nov 7, 2023

What does this PR implement/change/remove?

A set of vendor config format providers that aid in the translation of hw config options from one vendor to another. (Primarily for BIOS/BMC config settings)

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

  • Dell, Supermicro and asrockrack

Description for changelog/release notes

Adds a set of vendor config format providers that aid in the translation of hw config options from one vendor to another. (Primarily for BIOS/BMC config settings)

@splaspood splaspood marked this pull request as draft November 7, 2023 21:27
@splaspood splaspood marked this pull request as ready for review December 4, 2023 17:00
@splaspood splaspood force-pushed the hw-config-0 branch 2 times, most recently from 5a960f9 to 081acf9 Compare December 4, 2023 19:47
@splaspood splaspood marked this pull request as draft December 4, 2023 19:51
@splaspood splaspood force-pushed the hw-config-0 branch 4 times, most recently from 7b363ef to e6542bd Compare December 4, 2023 20:05
@splaspood splaspood force-pushed the hw-config-0 branch 3 times, most recently from 3de19a8 to b2f1dac Compare December 14, 2023 15:42
@splaspood splaspood marked this pull request as ready for review March 6, 2024 16:30
Copy link
Collaborator

@DoctorVin DoctorVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable as far as it goes. I do feel like some of the TODOs need a bit of a better answer (like what the current thinking is on supporting SRIOV on an arbitrary NIC on Dell, or supporting TPM/SRIOV on ARR).

IMO a README would be helpful here.

@splaspood splaspood merged commit 268411c into main Apr 15, 2024
3 checks passed
@splaspood splaspood deleted the hw-config-0 branch April 15, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants