-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VendorConfigManager implementations for dell, supermicro and asrockrack #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e4f36a
to
34ae332
Compare
5a960f9
to
081acf9
Compare
7b363ef
to
e6542bd
Compare
3de19a8
to
b2f1dac
Compare
b2f1dac
to
e6ff36b
Compare
DoctorVin
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable as far as it goes. I do feel like some of the TODOs need a bit of a better answer (like what the current thinking is on supporting SRIOV on an arbitrary NIC on Dell, or supporting TPM/SRIOV on ARR).
IMO a README would be helpful here.
joelrebel
reviewed
Mar 19, 2024
joelrebel
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
A set of vendor config format providers that aid in the translation of hw config options from one vendor to another. (Primarily for BIOS/BMC config settings)
Checklist
The HW vendor this change applies to (if applicable)
Description for changelog/release notes
Adds a set of vendor config format providers that aid in the translation of hw config options from one vendor to another. (Primarily for BIOS/BMC config settings)