Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made global constants and current_units type stable #92

Merged
merged 2 commits into from
Oct 23, 2024
Merged

made global constants and current_units type stable #92

merged 2 commits into from
Oct 23, 2024

Conversation

lllx125
Copy link
Collaborator

@lllx125 lllx125 commented Oct 19, 2024

No description provided.

@lllx125 lllx125 requested a review from rot4te October 19, 2024 00:01
rot4te
rot4te approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@rot4te rot4te left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look okay, but Lixing it would be really good if you would enter frequent comments (NOT docstrings) throughout your code to make the intent more clear.

@rot4te rot4te merged commit afd15b6 into main Oct 23, 2024
3 checks passed
@mattsignorelli mattsignorelli deleted the 88-fix_global_varible_type branch November 4, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rot4te rot4te rot4te approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lllx125 @rot4te