Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Species mass field #81

Closed
DavidSagan opened this issue Oct 7, 2024 · 3 comments
Closed

Rename Species mass field #81

DavidSagan opened this issue Oct 7, 2024 · 3 comments

Comments

@DavidSagan
Copy link
Member

One mistake I can see people making is to use species.mass instead of mass(species) and then wondering what went wrong. To help avoid this, I propose modifying the mass field of the Species struct. So instead of species.mass use the name species.mass_in_std_units (or any other name that is descriptive).

@rot4te
Copy link
Collaborator

rot4te commented Oct 8, 2024

I renamed the struct field in the most recent PR for branch '75+-edit_species_mass_unit', but I haven't renamed the same field in either the atomic or subatomic species dictionaries. Should I?

@DavidSagan
Copy link
Member Author

@rot4te Yes a rename in atomic and subatomic species dicts would make things clearer.

@DavidSagan
Copy link
Member Author

Thinking about it, a rename of the other fields of Species would make things clearer.

@rot4te rot4te closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants