Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unitful code added to physical_constants.jl should be elsewhere #79

Closed
rot4te opened this issue Oct 7, 2024 · 1 comment
Closed

Unitful code added to physical_constants.jl should be elsewhere #79

rot4te opened this issue Oct 7, 2024 · 1 comment
Assignees
@lllx125

Comments

@rot4te
Copy link
Collaborator

rot4te commented Oct 7, 2024

Per Alex, Dan, and Lixing's conversation on 2024-10-03, the constants with a _b prefix should have unitful units, however there is setup code in the file as well, which is inappropriate. We'll discuss more in meeting at 2024-10-07 @1215
@lllx125
Copy link
Collaborator

lllx125 commented Nov 4, 2024

done in the branch new_setunits

@lllx125 lllx125 closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lllx125 lllx125

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rot4te @lllx125