Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy workflows from blueapi, [still need to configure env values -not a code change] #664

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

copy workflows from blueapi, [still need to configure env values -not a code change] #664

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4dbacd6
copy from blueapi, still need to configure env values
stan-dot Nov 21, 2024
b2758c6
lint
stan-dot Nov 25, 2024
03f5494
add sonar config
stan-dot Nov 26, 2024
ff757fe
address comments
stan-dot Dec 11, 2024
8d8a696
deleted sonar properites
stan-dot Dec 11, 2024
e7cec0f
simplify codeql yaml logic
stan-dot Dec 11, 2024
e1b345f
respond to feedback
stan-dot Jan 10, 2025
698b7b2
remove unneeded inputs
stan-dot Jan 10, 2025
0a6fcc6
fix filename suffix
stan-dot Jan 16, 2025
999ec8c
reducing permissions
stan-dot Jan 20, 2025
1012be2
manual lint
stan-dot Jan 20, 2025
f7bf196
all good now
stan-dot Jan 20, 2025
d4724d0
add codeql analysis step
stan-dot Feb 3, 2025
629f54e
attempt to add SARIF upload
stan-dot Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/_codeql.yml
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing these lines:

      - name: Perform CodeQL Analysis
        uses: github/codeql-action/analyze@v3
        with:
          category: "/language:python"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post job cleanup.
CodeQL job status was configuration error.

what a misleading CI job, it was all green.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right I made a delete for the whole section instead of selectively

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushes to this branch will not trigger CodeQL, it only runs periodically.

To test your changes please hit the "run workflow" button and choose your branch here:
https://github.com/bluesky/ophyd-async/actions/workflows/periodic.yml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok nice I didn't know about that option

https://github.com/bluesky/ophyd-async/actions/runs/13112978405/job/36580769757

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this run was successfull but I haven't seen the successfull scans here https://github.com/bluesky/ophyd-async/security/code-scanning

investigating

Copy link
Contributor Author

@stan-dot stan-dot Feb 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debugging the path (?) image

Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: "CodeQL"

on:
workflow_call:

jobs:
analyze:
name: Analyze (python)
# Runner size impacts CodeQL analysis time. To learn more, please see:
# - https://gh.io/using-larger-runners (GitHub.com only)
runs-on: "ubuntu-latest"
timeout-minutes: 120
permissions:
# required for all workflows
security-events: write

steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: python
build-mode: none
2 changes: 2 additions & 0 deletions .github/workflows/periodic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,5 @@ jobs:
uses: ./.github/workflows/_tox.yml
with:
tox: docs build -- -b linkcheck
codeql:
uses: ./.github/workflows/_codeql.yml
Loading