bluepages: identity directory service #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnewbold
force-pushed
the
bnewbold/domesday
branch
from
16f1f31 to
3ffa202
Compare
bnewbold
force-pushed
the
bnewbold/domesday
branch
from
3ffa202 to
ee1f3ea
Compare
brianolson
reviewed
Feb 25, 2025
bnewbold
changed the title
brianolson
reviewed
Mar 5, 2025
|
|
||
| // Does HTTP requests to an identity server, using standard Lexicon endpoints | ||
| type APIDirectory struct { | ||
| Client *http.Client |
There was a problem hiding this comment.
I'm curious why indigo/xrpc.Client isn't the right thing here, and should we extend that so that it can be?
There was a problem hiding this comment.
In this case, it is very few endpoints, and it felt easy to just use http.Client directly. These endpoints would need updates to the agnostic API package (not just codegen), and I wanted direct access to the HTTP error codes.
| return app.Run(args) | ||
| } | ||
|
|
||
| func configLogger(cctx *cli.Context, writer io.Writer) *slog.Logger { |
There was a problem hiding this comment.
vs indigo/util/cliutil.SetupSlog() ?
There was a problem hiding this comment.
hmmm! haven't used that before. I have copied this configLogger snippet around between a bunch of projects, maybe I should add it as an alternative in cliutil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching identity service.
Resolverinterface; andSkipHandleVerificationflag onBaseDirectory#872identity.Directoryinterface)#identityevents)NOTE: this was previously called
domesday, it has been updated tobluepagesto be a bit more legible.